Skip to content

Commit 12be846

Browse files
anjalisinghai1Jeff Kirsher
authored andcommitted
i40e: Avoid adding the TCP-IPv4 filter twice
There wasn't a need to play the logic twice, it seems like a left over from when we had to add two PTYPEs for one filter. There should be no change in the number of filters that actually got added to the hardware. Change-ID: I5071d02eafd020b60e30eb96219f110f334eec85 Signed-off-by: Anjali Singhai Jain <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent fbd5e2d commit 12be846

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

drivers/net/ethernet/intel/i40e/i40e_txrx.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -271,19 +271,6 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi,
271271
fd_data->pctype, ret);
272272
}
273273

274-
fd_data->pctype = I40E_FILTER_PCTYPE_NONF_IPV4_TCP;
275-
276-
ret = i40e_program_fdir_filter(fd_data, raw_packet, pf, add);
277-
if (ret) {
278-
dev_info(&pf->pdev->dev,
279-
"Filter command send failed for PCTYPE %d (ret = %d)\n",
280-
fd_data->pctype, ret);
281-
err = true;
282-
} else {
283-
dev_info(&pf->pdev->dev, "Filter OK for PCTYPE %d (ret = %d)\n",
284-
fd_data->pctype, ret);
285-
}
286-
287274
return err ? -EOPNOTSUPP : 0;
288275
}
289276

0 commit comments

Comments
 (0)