infiniband: nes: Fix more direct skb list accesses.

davem330 · davem330 · commit 12ceaf8864c2 · 2018-11-09T21:19:44.000-08:00
The following:

	skb = skb-&gt;next;
	...
	if (skb == (struct sk_buff *)queue)

is transformed into:

	skb = skb_peek_next(skb, queue);
	...
	if (!skb)

Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/infiniband/hw/nes/nes_mgt.c b/drivers/infiniband/hw/nes/nes_mgt.c
@@ -223,11 +223,11 @@ static struct sk_buff *nes_get_next_skb(struct nes_device *nesdev, struct nes_qp
 		}
 
 		old_skb = skb;
-		skb = skb->next;
+		skb = skb_peek_next(skb, &nesqp->pau_list);
 		skb_unlink(old_skb, &nesqp->pau_list);
 		nes_mgt_free_skb(nesdev, old_skb, PCI_DMA_TODEVICE);
 		nes_rem_ref_cm_node(nesqp->cm_node);
-		if (skb == (struct sk_buff *)&nesqp->pau_list)
+		if (!skb)
 			goto out;
 	}
 	return skb;

Original file line number	Diff line number	Diff line change
`@@ -223,11 +223,11 @@ static struct sk_buff nes_get_next_skb(struct nes_device nesdev, struct nes_qp`
`223`	`223`	`}`
`224`	`224`
`225`	`225`	`old_skb = skb;`
`226`		`- skb = skb->next;`
	`226`	`+ skb = skb_peek_next(skb, &nesqp->pau_list);`
`227`	`227`	`skb_unlink(old_skb, &nesqp->pau_list);`
`228`	`228`	`nes_mgt_free_skb(nesdev, old_skb, PCI_DMA_TODEVICE);`
`229`	`229`	`nes_rem_ref_cm_node(nesqp->cm_node);`
`230`		`- if (skb == (struct sk_buff *)&nesqp->pau_list)`
	`230`	`+ if (!skb)`
`231`	`231`	`goto out;`
`232`	`232`	`}`
`233`	`233`	`return skb;`