Skip to content

Commit 13d2161

Browse files
committed
Revert "rpmsg: core: add support to power domains for devices"
This reverts commit 1ed3a93 which is commit fe782af upstream Rafael reports that this patch causes problems: > -rc2 looks good. There is a problem on dragonboard during boot that was > introduced in v4.14.71 that I didn't notice last week. We'll bisect it > and report back later this week. dragonboard on the other branches (4.9, > 4.18, mainline) looks fine. As Dan pointed out, during validation, we have bisected this issue on a dragonboard 410c (can't find root device) to the following commit for v4.14: [1ed3a93] rpmsg: core: add support to power domains for devices There is an on-going discussion on "[PATCH] rpmsg: core: add support to power domains for devices" about this patch having other dependencies and breaking something else on v4.14 as well. so drop it. Reported-by: Rafael Tinoco <[email protected]> Cc: Srinivas Kandagatla <[email protected]> Cc: Bjorn Andersson <[email protected]> Cc: Sasha Levin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 6447b34 commit 13d2161

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/rpmsg/rpmsg_core.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include <linux/module.h>
2424
#include <linux/rpmsg.h>
2525
#include <linux/of_device.h>
26-
#include <linux/pm_domain.h>
2726
#include <linux/slab.h>
2827

2928
#include "rpmsg_internal.h"
@@ -419,10 +418,6 @@ static int rpmsg_dev_probe(struct device *dev)
419418
struct rpmsg_endpoint *ept = NULL;
420419
int err;
421420

422-
err = dev_pm_domain_attach(dev, true);
423-
if (err)
424-
goto out;
425-
426421
if (rpdrv->callback) {
427422
strncpy(chinfo.name, rpdev->id.name, RPMSG_NAME_SIZE);
428423
chinfo.src = rpdev->src;
@@ -464,8 +459,6 @@ static int rpmsg_dev_remove(struct device *dev)
464459

465460
rpdrv->remove(rpdev);
466461

467-
dev_pm_domain_detach(dev, true);
468-
469462
if (rpdev->ept)
470463
rpmsg_destroy_ept(rpdev->ept);
471464

0 commit comments

Comments
 (0)