Skip to content

Commit 1400208

Browse files
IoanaCiorneikuba-moo
authored andcommitted
dpaa2-mac: remove a comment regarding pause settings
The MC firmware takes these PAUSE/ASYM_PAUSE flags provided by the driver, transforms them back into rx/tx pause enablement status and applies them to hardware. We are not losing information by this transformation, thus remove the comment. Signed-off-by: Ioana Ciornei <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
1 parent ca76334 commit 1400208

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,9 +181,6 @@ static void dpaa2_mac_link_up(struct phylink_config *config,
181181
else if (duplex == DUPLEX_FULL)
182182
dpmac_state->options &= ~DPMAC_LINK_OPT_HALF_DUPLEX;
183183

184-
/* This is lossy; the firmware really should take the pause
185-
* enablement status rather than pause/asym pause status.
186-
*/
187184
if (rx_pause)
188185
dpmac_state->options |= DPMAC_LINK_OPT_PAUSE;
189186
else

0 commit comments

Comments
 (0)