Skip to content

Commit 1411b52

Browse files
mpeherbertx
authored andcommitted
crypto: vmx - Remove overly verbose printk from AES init routines
In the vmx AES init routines we do a printk(KERN_INFO ...) to report the fallback implementation we're using. However with a slow console this can significantly affect the speed of crypto operations. Using 'cryptsetup benchmark' the removal of the printk() leads to a ~5x speedup for aes-cbc decryption. So remove them. Fixes: 8676590 ("crypto: vmx - Adding AES routines for VMX module") Fixes: 8c755ac ("crypto: vmx - Adding CBC routines for VMX module") Fixes: 4f7f60d ("crypto: vmx - Adding CTR routines for VMX module") Fixes: cc333cd ("crypto: vmx - Adding GHASH routines for VMX module") Cc: [email protected] # v4.1+ Signed-off-by: Michael Ellerman <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent 6caf7ad commit 1411b52

File tree

4 files changed

+0
-9
lines changed

4 files changed

+0
-9
lines changed

drivers/crypto/vmx/aes.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ static int p8_aes_init(struct crypto_tfm *tfm)
4848
alg, PTR_ERR(fallback));
4949
return PTR_ERR(fallback);
5050
}
51-
printk(KERN_INFO "Using '%s' as fallback implementation.\n",
52-
crypto_tfm_alg_driver_name((struct crypto_tfm *) fallback));
5351

5452
crypto_cipher_set_flags(fallback,
5553
crypto_cipher_get_flags((struct

drivers/crypto/vmx/aes_cbc.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,6 @@ static int p8_aes_cbc_init(struct crypto_tfm *tfm)
5252
alg, PTR_ERR(fallback));
5353
return PTR_ERR(fallback);
5454
}
55-
printk(KERN_INFO "Using '%s' as fallback implementation.\n",
56-
crypto_skcipher_driver_name(fallback));
57-
5855

5956
crypto_skcipher_set_flags(
6057
fallback,

drivers/crypto/vmx/aes_ctr.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ static int p8_aes_ctr_init(struct crypto_tfm *tfm)
5050
alg, PTR_ERR(fallback));
5151
return PTR_ERR(fallback);
5252
}
53-
printk(KERN_INFO "Using '%s' as fallback implementation.\n",
54-
crypto_skcipher_driver_name(fallback));
5553

5654
crypto_skcipher_set_flags(
5755
fallback,

drivers/crypto/vmx/ghash.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ static int p8_ghash_init_tfm(struct crypto_tfm *tfm)
6464
alg, PTR_ERR(fallback));
6565
return PTR_ERR(fallback);
6666
}
67-
printk(KERN_INFO "Using '%s' as fallback implementation.\n",
68-
crypto_tfm_alg_driver_name(crypto_shash_tfm(fallback)));
6967

7068
crypto_shash_set_flags(fallback,
7169
crypto_shash_get_flags((struct crypto_shash

0 commit comments

Comments
 (0)