Skip to content

Commit 14469a8

Browse files
torvaldsH. Peter Anvin
authored andcommitted
x86: disable static NOPLs on 32 bits
On 32-bit, at least the generic nops are fairly reasonable, but the default nops for 64-bit really look pretty sad, and the P6 nops really do look better. So I would suggest perhaps moving the static P6 nop selection into the CONFIG_X86_64 thing. The alternative is to just get rid of that static nop selection, and just have two cases: 32-bit and 64-bit, and just pick obviously safe cases for them. Signed-off-by: H. Peter Anvin <[email protected]>
1 parent 0253398 commit 14469a8

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

arch/x86/Kconfig.cpu

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -382,14 +382,17 @@ config X86_OOSTORE
382382
# P6_NOPs are a relatively minor optimization that require a family >=
383383
# 6 processor, except that it is broken on certain VIA chips.
384384
# Furthermore, AMD chips prefer a totally different sequence of NOPs
385-
# (which work on all CPUs). As a result, disallow these if we're
386-
# compiling X86_GENERIC but not X86_64 (these NOPs do work on all
387-
# x86-64 capable chips); the list of processors in the right-hand clause
388-
# are the cores that benefit from this optimization.
385+
# (which work on all CPUs). In addition, it looks like Virtual PC
386+
# does not understand them.
387+
#
388+
# As a result, disallow these if we're not compiling for X86_64 (these
389+
# NOPs do work on all x86-64 capable chips); the list of processors in
390+
# the right-hand clause are the cores that benefit from this optimization.
389391
#
390392
config X86_P6_NOP
391393
def_bool y
392-
depends on (X86_64 || !X86_GENERIC) && (M686 || MPENTIUMII || MPENTIUMIII || MPENTIUMM || MCORE2 || MPENTIUM4 || MPSC)
394+
depends on X86_64
395+
depends on (MCORE2 || MPENTIUM4 || MPSC)
393396

394397
config X86_TSC
395398
def_bool y

0 commit comments

Comments
 (0)