Skip to content

Commit 14f0413

Browse files
hmbeddedbroonie
authored andcommitted
ASoC: pcm512x: Remove hardcoding of pll-lock to GPIO4
Currently GPIO4 is hardcoded to output the pll-lock signal. Unfortunately this is after the pll-out GPIO is configured which is selectable in the device tree. Therefore it is not possible to use GPIO4 for pll-out. Therefore this patch removes the configuration of GPIO4. Signed-off-by: Howard Mitchell <[email protected]> Signed-off-by: Mark Brown <[email protected]>
1 parent c517d83 commit 14f0413

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

sound/soc/codecs/pcm512x.c

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1156,25 +1156,6 @@ static int pcm512x_hw_params(struct snd_pcm_substream *substream,
11561156
ret, pcm512x->pll_out);
11571157
return ret;
11581158
}
1159-
1160-
gpio = PCM512x_G1OE << (4 - 1);
1161-
ret = regmap_update_bits(pcm512x->regmap, PCM512x_GPIO_EN,
1162-
gpio, gpio);
1163-
if (ret != 0) {
1164-
dev_err(codec->dev, "Failed to enable gpio %d: %d\n",
1165-
4, ret);
1166-
return ret;
1167-
}
1168-
1169-
gpio = PCM512x_GPIO_OUTPUT_1 + 4 - 1;
1170-
ret = regmap_update_bits(pcm512x->regmap, gpio,
1171-
PCM512x_GxSL, PCM512x_GxSL_PLLLK);
1172-
if (ret != 0) {
1173-
dev_err(codec->dev,
1174-
"Failed to output pll lock on %d: %d\n",
1175-
ret, 4);
1176-
return ret;
1177-
}
11781159
}
11791160

11801161
ret = regmap_update_bits(pcm512x->regmap, PCM512x_SYNCHRONIZE,

0 commit comments

Comments
 (0)