Skip to content

Commit 15324b2

Browse files
committed
Merge branch 'sfc-MCDI-cleanups'
Edward Cree says: ==================== sfc: small MCDI cleanups Giving the full MCDI event rather than just the code can aid in debugging. While fixing this I noticed an outdated comment. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 4120dab + 53172d9 commit 15324b2

File tree

1 file changed

+4
-3
lines changed
  • drivers/net/ethernet/sfc

1 file changed

+4
-3
lines changed

drivers/net/ethernet/sfc/mcdi.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1301,7 +1301,7 @@ static void efx_mcdi_abandon(struct efx_nic *efx)
13011301
efx_schedule_reset(efx, RESET_TYPE_MCDI_TIMEOUT);
13021302
}
13031303

1304-
/* Called from falcon_process_eventq for MCDI events */
1304+
/* Called from efx_farch_ev_process and efx_ef10_ev_process for MCDI events */
13051305
void efx_mcdi_process_event(struct efx_channel *channel,
13061306
efx_qword_t *event)
13071307
{
@@ -1389,8 +1389,9 @@ void efx_mcdi_process_event(struct efx_channel *channel,
13891389
MCDI_EVENT_FIELD(*event, PROXY_RESPONSE_RC));
13901390
break;
13911391
default:
1392-
netif_err(efx, hw, efx->net_dev, "Unknown MCDI event 0x%x\n",
1393-
code);
1392+
netif_err(efx, hw, efx->net_dev,
1393+
"Unknown MCDI event " EFX_QWORD_FMT "\n",
1394+
EFX_QWORD_VAL(*event));
13941395
}
13951396
}
13961397

0 commit comments

Comments
 (0)