Skip to content

Commit 15c9738

Browse files
QiushiWudavem330
authored andcommitted
qlcnic: fix missing release in qlcnic_83xx_interrupt_test.
In function qlcnic_83xx_interrupt_test(), function qlcnic_83xx_diag_alloc_res() is not handled by function qlcnic_83xx_diag_free_res() after a call of the function qlcnic_alloc_mbx_args() failed. Fix this issue by adding a jump target "fail_mbx_args", and jump to this new target when qlcnic_alloc_mbx_args() failed. Fixes: b6b4316 ("qlcnic: Handle qlcnic_alloc_mbx_args() failure") Signed-off-by: Qiushi Wu <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 5d14c30 commit 15c9738

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3651,7 +3651,7 @@ int qlcnic_83xx_interrupt_test(struct net_device *netdev)
36513651
ahw->diag_cnt = 0;
36523652
ret = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_INTRPT_TEST);
36533653
if (ret)
3654-
goto fail_diag_irq;
3654+
goto fail_mbx_args;
36553655

36563656
if (adapter->flags & QLCNIC_MSIX_ENABLED)
36573657
intrpt_id = ahw->intr_tbl[0].id;
@@ -3681,6 +3681,8 @@ int qlcnic_83xx_interrupt_test(struct net_device *netdev)
36813681

36823682
done:
36833683
qlcnic_free_mbx_args(&cmd);
3684+
3685+
fail_mbx_args:
36843686
qlcnic_83xx_diag_free_res(netdev, drv_sds_rings);
36853687

36863688
fail_diag_irq:

0 commit comments

Comments
 (0)