Skip to content

Commit 15f96ed

Browse files
author
Mukesh Kacker
committed
RDS: mark netdev UP for intfs added post module load
When interfaces are brought up after module load, a NETDEV_UP event for which no matching port exists triggers re-initialization of active bonding data structures. The initialization however missed marking the layer as up in flag tracking which layers are up. The fix here marks that layer as UP in the flags since the initialization is triggered by the NETDEV_UP event processing! Orabug: 20130536 Signed-off-by: Mukesh Kacker <[email protected]> Acked-by: Chien Yen < [email protected]>
1 parent 60c41a4 commit 15f96ed

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

net/rds/ib.c

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2290,6 +2290,22 @@ static void rds_ib_joining_ip(struct work_struct *_work)
22902290
ifa->ifa_broadcast,
22912291
ifa->ifa_mask);
22922292
}
2293+
/*
2294+
* Processing triggered by a NETDEV_UP event
2295+
* mark the NETDEV layer UP.
2296+
* (No failback/failover processing done for
2297+
* this initial NETDEV_UP event for a new
2298+
* device!)
2299+
*/
2300+
ip_config[port].port_layerflags |=
2301+
RDSIBP_STATUS_NETDEVUP;
2302+
if (!(ip_config[port].dev->flags & IFF_UP)) {
2303+
printk(KERN_WARNING "RDS/IB: Device %s "
2304+
"flag NOT marked UP in "
2305+
"NETDEV_UP(joining ip) "
2306+
"processing!\n",
2307+
ip_config[port].dev->name);
2308+
}
22932309
}
22942310
}
22952311
printk(KERN_INFO "RDS/IB: Updated IP configuration..\n");

0 commit comments

Comments
 (0)