Skip to content

Commit 162bdaf

Browse files
committed
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
Pull s390 fixes from Martin Schwidefsky: "A couple of bux fixes, notable are the regression with ptrace vs restarting system calls and the patch for kdump to be able to copy from virtual memory" * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux: s390: fix system call restart after inferior call s390: Allow vmalloc target buffers for copy_from_oldmem() s390/sclp: properly detect line mode console s390/kprobes: add exrl to list of prohibited opcodes s390/3270: fix return value check in tty3270_resize_work()
2 parents d0e639c + dbbfe48 commit 162bdaf

File tree

6 files changed

+33
-27
lines changed

6 files changed

+33
-27
lines changed

arch/s390/kernel/crash_dump.c

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -40,28 +40,26 @@ static inline void *load_real_addr(void *addr)
4040
}
4141

4242
/*
43-
* Copy up to one page to vmalloc or real memory
43+
* Copy real to virtual or real memory
4444
*/
45-
static ssize_t copy_page_real(void *buf, void *src, size_t csize)
45+
static int copy_from_realmem(void *dest, void *src, size_t count)
4646
{
47-
size_t size;
47+
unsigned long size;
48+
int rc;
4849

49-
if (is_vmalloc_addr(buf)) {
50-
BUG_ON(csize >= PAGE_SIZE);
51-
/* If buf is not page aligned, copy first part */
52-
size = min(roundup(__pa(buf), PAGE_SIZE) - __pa(buf), csize);
53-
if (size) {
54-
if (memcpy_real(load_real_addr(buf), src, size))
55-
return -EFAULT;
56-
buf += size;
57-
src += size;
58-
}
59-
/* Copy second part */
60-
size = csize - size;
61-
return (size) ? memcpy_real(load_real_addr(buf), src, size) : 0;
62-
} else {
63-
return memcpy_real(buf, src, csize);
64-
}
50+
if (!count)
51+
return 0;
52+
if (!is_vmalloc_or_module_addr(dest))
53+
return memcpy_real(dest, src, count);
54+
do {
55+
size = min(count, PAGE_SIZE - (__pa(dest) & ~PAGE_MASK));
56+
if (memcpy_real(load_real_addr(dest), src, size))
57+
return -EFAULT;
58+
count -= size;
59+
dest += size;
60+
src += size;
61+
} while (count);
62+
return 0;
6563
}
6664

6765
/*
@@ -114,7 +112,7 @@ static ssize_t copy_oldmem_page_kdump(char *buf, size_t csize,
114112
rc = copy_to_user_real((void __force __user *) buf,
115113
(void *) src, csize);
116114
else
117-
rc = copy_page_real(buf, (void *) src, csize);
115+
rc = copy_from_realmem(buf, (void *) src, csize);
118116
return (rc == 0) ? rc : csize;
119117
}
120118

@@ -210,7 +208,7 @@ int copy_from_oldmem(void *dest, void *src, size_t count)
210208
if (OLDMEM_BASE) {
211209
if ((unsigned long) src < OLDMEM_SIZE) {
212210
copied = min(count, OLDMEM_SIZE - (unsigned long) src);
213-
rc = memcpy_real(dest, src + OLDMEM_BASE, copied);
211+
rc = copy_from_realmem(dest, src + OLDMEM_BASE, copied);
214212
if (rc)
215213
return rc;
216214
}
@@ -223,7 +221,7 @@ int copy_from_oldmem(void *dest, void *src, size_t count)
223221
return rc;
224222
}
225223
}
226-
return memcpy_real(dest + copied, src + copied, count - copied);
224+
return copy_from_realmem(dest + copied, src + copied, count - copied);
227225
}
228226

229227
/*

arch/s390/kernel/entry.S

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ sysc_sigpending:
266266
tm __TI_flags+3(%r12),_TIF_SYSCALL
267267
jno sysc_return
268268
lm %r2,%r7,__PT_R2(%r11) # load svc arguments
269+
l %r10,__TI_sysc_table(%r12) # 31 bit system call table
269270
xr %r8,%r8 # svc 0 returns -ENOSYS
270271
clc __PT_INT_CODE+2(2,%r11),BASED(.Lnr_syscalls+2)
271272
jnl sysc_nr_ok # invalid svc number -> do svc 0

arch/s390/kernel/entry64.S

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,7 @@ sysc_sigpending:
297297
tm __TI_flags+7(%r12),_TIF_SYSCALL
298298
jno sysc_return
299299
lmg %r2,%r7,__PT_R2(%r11) # load svc arguments
300+
lg %r10,__TI_sysc_table(%r12) # address of system call table
300301
lghi %r8,0 # svc 0 returns -ENOSYS
301302
llgh %r1,__PT_INT_CODE+2(%r11) # load new svc number
302303
cghi %r1,NR_syscalls

arch/s390/kernel/kprobes.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,11 @@ static int __kprobes is_prohibited_opcode(kprobe_opcode_t *insn)
6767
case 0xac: /* stnsm */
6868
case 0xad: /* stosm */
6969
return -EINVAL;
70+
case 0xc6:
71+
switch (insn[0] & 0x0f) {
72+
case 0x00: /* exrl */
73+
return -EINVAL;
74+
}
7075
}
7176
switch (insn[0]) {
7277
case 0x0101: /* pr */
@@ -180,7 +185,6 @@ static int __kprobes is_insn_relative_long(kprobe_opcode_t *insn)
180185
break;
181186
case 0xc6:
182187
switch (insn[0] & 0x0f) {
183-
case 0x00: /* exrl */
184188
case 0x02: /* pfdrl */
185189
case 0x04: /* cghrl */
186190
case 0x05: /* chrl */

drivers/s390/char/sclp_cmd.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,11 @@ bool __init sclp_has_linemode(void)
145145

146146
if (sccb->header.response_code != 0x20)
147147
return 0;
148-
if (sccb->sclp_send_mask & (EVTYP_MSG_MASK | EVTYP_PMSGCMD_MASK))
149-
return 1;
150-
return 0;
148+
if (!(sccb->sclp_send_mask & (EVTYP_OPCMD_MASK | EVTYP_PMSGCMD_MASK)))
149+
return 0;
150+
if (!(sccb->sclp_receive_mask & (EVTYP_MSG_MASK | EVTYP_PMSGCMD_MASK)))
151+
return 0;
152+
return 1;
151153
}
152154

153155
bool __init sclp_has_vt220(void)

drivers/s390/char/tty3270.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -810,7 +810,7 @@ static void tty3270_resize_work(struct work_struct *work)
810810
struct winsize ws;
811811

812812
screen = tty3270_alloc_screen(tp->n_rows, tp->n_cols);
813-
if (!screen)
813+
if (IS_ERR(screen))
814814
return;
815815
/* Switch to new output size */
816816
spin_lock_bh(&tp->view.lock);

0 commit comments

Comments
 (0)