Skip to content

Commit 177c47a

Browse files
Wengang-oracleSantoshShilimkar
authored andcommitted
rds: remove the _reuse_ rds ib pool statistics
Orabug: 22124214 fix a regress introduced by ceb99ba The above commit introduced the two new statistics to rds_ib_statistics. uint64_t s_ib_rdma_mr_1m_pool_reuse; uint64_t s_ib_rdma_mr_8k_pool_reuse; But didn't have rds-info changed accordingly thus rds-info gets shifted stats. this removes these two stats. Acked-by: Santosh Shilimkar <[email protected]> Acked-by: Ajaykumar Hotchandani <[email protected]> Signed-off-by: Wengang Wang <[email protected]>
1 parent d2cf302 commit 177c47a

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

net/rds/ib.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -490,8 +490,6 @@ struct rds_ib_statistics {
490490
uint64_t s_ib_rdma_mr_1m_pool_flush;
491491
uint64_t s_ib_rdma_mr_1m_pool_wait;
492492
uint64_t s_ib_rdma_mr_1m_pool_depleted;
493-
uint64_t s_ib_rdma_mr_1m_pool_reuse;
494-
uint64_t s_ib_rdma_mr_8k_pool_reuse;
495493
uint64_t s_ib_atomic_cswp;
496494
uint64_t s_ib_atomic_fadd;
497495
uint64_t s_ib_srq_lows;

net/rds/ib_rdma.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -320,10 +320,6 @@ static inline struct rds_ib_mr *rds_ib_reuse_fmr(struct rds_ib_mr_pool *pool)
320320
clear_bit(CLEAN_LIST_BUSY_BIT, flag);
321321
preempt_enable();
322322
if (ibmr) {
323-
if (pool->pool_type == RDS_IB_MR_8K_POOL)
324-
rds_ib_stats_inc(s_ib_rdma_mr_8k_pool_reuse);
325-
else
326-
rds_ib_stats_inc(s_ib_rdma_mr_1m_pool_reuse);
327323
spin_lock_bh(&pool->busy_lock);
328324
list_add(&ibmr->pool_list, &pool->busy_list);
329325
spin_unlock_bh(&pool->busy_lock);

0 commit comments

Comments
 (0)