Skip to content

Commit 1798745

Browse files
mkumardvinodkoul
authored andcommitted
dmaengine: tegra210-adma: Use div_u64 for 64 bit division
The ADMA base and page address are represented using a 64-bit variable. To accurately derive the exact ADMA page number provided from the DT properties, use the div_u64() to divide the address difference between adma page and base address by the page offset. This change fixes the below error "ERROR: modpost: "__udivdi3" [drivers/dma/tegra210-adma.ko] undefined! ld: drivers/dma/tegra210-adma.o: in function `tegra_adma_probe': tegra210-adma.c:(.text+0x12cf): undefined reference to `__udivdi3'" Fixes: 68811c9 ("dmaengine: tegra210-adma: Support channel page") Cc: [email protected] Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Signed-off-by: Mohan Kumar D <[email protected]> Reviewed-by: Jon Hunter <[email protected]> Acked-by: Thierry Reding <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 2014c95 commit 1798745

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

drivers/dma/tegra210-adma.c

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,8 @@ static int tegra_adma_probe(struct platform_device *pdev)
887887
const struct tegra_adma_chip_data *cdata;
888888
struct tegra_adma *tdma;
889889
struct resource *res_page, *res_base;
890-
int ret, i, page_no;
890+
u64 page_no, page_offset;
891+
int ret, i;
891892

892893
cdata = of_device_get_match_data(&pdev->dev);
893894
if (!cdata) {
@@ -914,10 +915,16 @@ static int tegra_adma_probe(struct platform_device *pdev)
914915

915916
res_base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "global");
916917
if (res_base) {
917-
page_no = (res_page->start - res_base->start) / cdata->ch_base_offset;
918-
if (page_no <= 0)
918+
if (WARN_ON(res_page->start <= res_base->start))
919919
return -EINVAL;
920-
tdma->ch_page_no = page_no - 1;
920+
921+
page_offset = res_page->start - res_base->start;
922+
page_no = div_u64(page_offset, cdata->ch_base_offset);
923+
924+
if (WARN_ON(page_no == 0))
925+
return -EINVAL;
926+
927+
tdma->ch_page_no = lower_32_bits(page_no) - 1;
921928
tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
922929
if (IS_ERR(tdma->base_addr))
923930
return PTR_ERR(tdma->base_addr);

0 commit comments

Comments
 (0)