Skip to content

Commit 17e1be3

Browse files
Michael Chandavem330
authored andcommitted
bnxt_en: Treat health register value 0 as valid in bnxt_try_reover_fw().
The retry loop in bnxt_try_recover_fw() should not abort when the health register value is 0. It is a valid value that indicates the firmware is booting up. Fixes: 861aae7 ("bnxt_en: Enhance retry of the first message to the firmware.") Reviewed-by: Edwin Peer <[email protected]> Signed-off-by: Michael Chan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0d77036 commit 17e1be3

File tree

1 file changed

+2
-2
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+2
-2
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9532,8 +9532,8 @@ static int bnxt_try_recover_fw(struct bnxt *bp)
95329532
do {
95339533
sts = bnxt_fw_health_readl(bp, BNXT_FW_HEALTH_REG);
95349534
rc = __bnxt_hwrm_ver_get(bp, true);
9535-
if (!sts || (!BNXT_FW_IS_BOOTING(sts) &&
9536-
!BNXT_FW_IS_RECOVERING(sts)))
9535+
if (!BNXT_FW_IS_BOOTING(sts) &&
9536+
!BNXT_FW_IS_RECOVERING(sts))
95379537
break;
95389538
retry++;
95399539
} while (rc == -EBUSY && retry < BNXT_FW_RETRY);

0 commit comments

Comments
 (0)