rxrpc: remove redundant proc_remove call

Colin Ian King · davem330 · commit 1820dd0633b9 · 2017-06-04T19:59:11.000-04:00
The proc_remove call is dead code as it occurs after a return and
hence can never be called. Remove it.

Detected by CoverityScan, CID#1437743 ("Logically dead code")

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Acked-by: David Howells &lt;dhowells@redhat.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/rxrpc/net_ns.c b/net/rxrpc/net_ns.c
@@ -59,7 +59,6 @@ static __net_init int rxrpc_init_net(struct net *net)
 	proc_create("conns", 0444, rxnet->proc_net, &rxrpc_connection_seq_fops);
 	return 0;
 
-	proc_remove(rxnet->proc_net);
 err_proc:
 	return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,6 @@ static __net_init int rxrpc_init_net(struct net *net)`
`59`	`59`	`proc_create("conns", 0444, rxnet->proc_net, &rxrpc_connection_seq_fops);`
`60`	`60`	`return 0;`
`61`	`61`
`62`		`- proc_remove(rxnet->proc_net);`
`63`	`62`	`err_proc:`
`64`	`63`	`return ret;`
`65`	`64`	`}`