Skip to content

Commit 1826640

Browse files
jhovoldgregkh
authored andcommitted
USB: cdc-acm: fix TIOCMIWAIT
The TIOCMIWAIT implementation would return -EINVAL if any of the three supported signals were included in the mask. Instead of returning an error in case TIOCM_CTS is included, simply drop the mask check completely, which is in accordance with how other drivers implement this ioctl. Fixes: 5a6a62b ("cdc-acm: add TIOCMIWAIT") Cc: stable <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Acked-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 7309aa8 commit 1826640

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/usb/class/cdc-acm.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -932,8 +932,6 @@ static int wait_serial_change(struct acm *acm, unsigned long arg)
932932
DECLARE_WAITQUEUE(wait, current);
933933
struct async_icount old, new;
934934

935-
if (arg & (TIOCM_DSR | TIOCM_RI | TIOCM_CD))
936-
return -EINVAL;
937935
do {
938936
spin_lock_irq(&acm->read_lock);
939937
old = acm->oldcount;

0 commit comments

Comments
 (0)