Skip to content

Commit 185c66e

Browse files
committed
drm/i915/skl: Fix rc6 based gpu/system hang
For all gt3 and gt4 skylake variants, extend the usage of WaRsDisableCoarsePowerGating for all revisions. Without this gt3 and gt4 skylakes up to atleast rev 0xa can gpu hang or system hang. Cc: Abdiel Janulgue <[email protected]> Cc: Ben Widawsky <[email protected]> Cc: Timo Aaltonen <[email protected]> Cc: <[email protected]> Reported-by: Mikael Djurfeldt <[email protected]> References: https://bugs.freedesktop.org/show_bug.cgi?id=94161 Signed-off-by: Mika Kuoppala <[email protected]> Reviewed-by: Ben Widawsky <[email protected]> Tested-by: Timo Aaltonen <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 3f10e82 commit 185c66e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/i915/i915_drv.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2642,8 +2642,9 @@ struct drm_i915_cmd_table {
26422642

26432643
/* WaRsDisableCoarsePowerGating:skl,bxt */
26442644
#define NEEDS_WaRsDisableCoarsePowerGating(dev) (IS_BXT_REVID(dev, 0, BXT_REVID_A1) || \
2645-
((IS_SKL_GT3(dev) || IS_SKL_GT4(dev)) && \
2646-
IS_SKL_REVID(dev, 0, SKL_REVID_F0)))
2645+
IS_SKL_GT3(dev) || \
2646+
IS_SKL_GT4(dev))
2647+
26472648
/*
26482649
* dp aux and gmbus irq on gen4 seems to be able to generate legacy interrupts
26492650
* even when in MSI mode. This results in spurious interrupt warnings if the

0 commit comments

Comments
 (0)