Skip to content

Commit 189addc

Browse files
committed
Merge tag 'vfio-v4.10-final' of git://github.com/awilliam/linux-vfio
Pull VFIO fix from Alex Williamson: "Fix regression in attaching groups to existing container for SPAPR IOMMU backend (Alexey Kardashevskiy)" * tag 'vfio-v4.10-final' of git://github.com/awilliam/linux-vfio: vfio/spapr_tce: Set window when adding additional groups to container
2 parents 59e8f10 + 930a42d commit 189addc

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

drivers/vfio/vfio_iommu_spapr_tce.c

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1245,6 +1245,8 @@ static void tce_iommu_release_ownership_ddw(struct tce_container *container,
12451245
static long tce_iommu_take_ownership_ddw(struct tce_container *container,
12461246
struct iommu_table_group *table_group)
12471247
{
1248+
long i, ret = 0;
1249+
12481250
if (!table_group->ops->create_table || !table_group->ops->set_window ||
12491251
!table_group->ops->release_ownership) {
12501252
WARN_ON_ONCE(1);
@@ -1253,7 +1255,27 @@ static long tce_iommu_take_ownership_ddw(struct tce_container *container,
12531255

12541256
table_group->ops->take_ownership(table_group);
12551257

1258+
/* Set all windows to the new group */
1259+
for (i = 0; i < IOMMU_TABLE_GROUP_MAX_TABLES; ++i) {
1260+
struct iommu_table *tbl = container->tables[i];
1261+
1262+
if (!tbl)
1263+
continue;
1264+
1265+
ret = table_group->ops->set_window(table_group, i, tbl);
1266+
if (ret)
1267+
goto release_exit;
1268+
}
1269+
12561270
return 0;
1271+
1272+
release_exit:
1273+
for (i = 0; i < IOMMU_TABLE_GROUP_MAX_TABLES; ++i)
1274+
table_group->ops->unset_window(table_group, i);
1275+
1276+
table_group->ops->release_ownership(table_group);
1277+
1278+
return ret;
12571279
}
12581280

12591281
static int tce_iommu_attach_group(void *iommu_data,

0 commit comments

Comments
 (0)