Skip to content

Commit 1922eec

Browse files
author
Ingo Molnar
committed
Merge tag 'perf-urgent-for-mingo-4.13-20170710' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
Pull perf/urgent fixes from Arnaldo Carvalho de Melo: - Fix attr.exclude_kernel setting for default cycles:p (Arnaldo Carvalho de Melo) - Fix broken arrow at row 0 connecting jmp instruction to its target in the annotate TUI (Jin Yao) Signed-off-by: Arnaldo Carvalho de Melo <[email protected]> Signed-off-by: Ingo Molnar <[email protected]>
2 parents dbf5806 + 80f6258 commit 1922eec

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

tools/perf/ui/browser.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,7 @@ static void __ui_browser__line_arrow_down(struct ui_browser *browser,
704704
ui_browser__gotorc(browser, row, column + 1);
705705
SLsmg_draw_hline(2);
706706

707-
if (row++ == 0)
707+
if (++row == 0)
708708
goto out;
709709
} else
710710
row = 0;

tools/perf/util/evsel.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ struct perf_evsel *perf_evsel__new_cycles(void)
273273
struct perf_event_attr attr = {
274274
.type = PERF_TYPE_HARDWARE,
275275
.config = PERF_COUNT_HW_CPU_CYCLES,
276-
.exclude_kernel = 1,
276+
.exclude_kernel = geteuid() != 0,
277277
};
278278
struct perf_evsel *evsel;
279279

@@ -298,8 +298,10 @@ struct perf_evsel *perf_evsel__new_cycles(void)
298298
goto out;
299299

300300
/* use asprintf() because free(evsel) assumes name is allocated */
301-
if (asprintf(&evsel->name, "cycles%.*s",
302-
attr.precise_ip ? attr.precise_ip + 1 : 0, ":ppp") < 0)
301+
if (asprintf(&evsel->name, "cycles%s%s%.*s",
302+
(attr.precise_ip || attr.exclude_kernel) ? ":" : "",
303+
attr.exclude_kernel ? "u" : "",
304+
attr.precise_ip ? attr.precise_ip + 1 : 0, "ppp") < 0)
303305
goto error_free;
304306
out:
305307
return evsel;

0 commit comments

Comments
 (0)