Skip to content

Commit 1991722

Browse files
committed
mm/mmu_notifiers: Use 'subscription' as the variable name for mmu_notifier
The 'subscription' is placed on the 'notifier_subscriptions' list. This eliminates the poor name 'mn' for this variable. Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent 984cfe4 commit 1991722

File tree

2 files changed

+117
-96
lines changed

2 files changed

+117
-96
lines changed

include/linux/mmu_notifier.h

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ struct mmu_notifier_ops {
7373
* through the gart alias address, so leading to memory
7474
* corruption.
7575
*/
76-
void (*release)(struct mmu_notifier *mn,
76+
void (*release)(struct mmu_notifier *subscription,
7777
struct mm_struct *mm);
7878

7979
/*
@@ -85,7 +85,7 @@ struct mmu_notifier_ops {
8585
* Start-end is necessary in case the secondary MMU is mapping the page
8686
* at a smaller granularity than the primary MMU.
8787
*/
88-
int (*clear_flush_young)(struct mmu_notifier *mn,
88+
int (*clear_flush_young)(struct mmu_notifier *subscription,
8989
struct mm_struct *mm,
9090
unsigned long start,
9191
unsigned long end);
@@ -95,7 +95,7 @@ struct mmu_notifier_ops {
9595
* latter, it is supposed to test-and-clear the young/accessed bitflag
9696
* in the secondary pte, but it may omit flushing the secondary tlb.
9797
*/
98-
int (*clear_young)(struct mmu_notifier *mn,
98+
int (*clear_young)(struct mmu_notifier *subscription,
9999
struct mm_struct *mm,
100100
unsigned long start,
101101
unsigned long end);
@@ -106,15 +106,15 @@ struct mmu_notifier_ops {
106106
* frequently used without actually clearing the flag or tearing
107107
* down the secondary mapping on the page.
108108
*/
109-
int (*test_young)(struct mmu_notifier *mn,
109+
int (*test_young)(struct mmu_notifier *subscription,
110110
struct mm_struct *mm,
111111
unsigned long address);
112112

113113
/*
114114
* change_pte is called in cases that pte mapping to page is changed:
115115
* for example, when ksm remaps pte to point to a new shared page.
116116
*/
117-
void (*change_pte)(struct mmu_notifier *mn,
117+
void (*change_pte)(struct mmu_notifier *subscription,
118118
struct mm_struct *mm,
119119
unsigned long address,
120120
pte_t pte);
@@ -169,9 +169,9 @@ struct mmu_notifier_ops {
169169
* invalidate_range_end.
170170
*
171171
*/
172-
int (*invalidate_range_start)(struct mmu_notifier *mn,
172+
int (*invalidate_range_start)(struct mmu_notifier *subscription,
173173
const struct mmu_notifier_range *range);
174-
void (*invalidate_range_end)(struct mmu_notifier *mn,
174+
void (*invalidate_range_end)(struct mmu_notifier *subscription,
175175
const struct mmu_notifier_range *range);
176176

177177
/*
@@ -192,8 +192,10 @@ struct mmu_notifier_ops {
192192
* of what was passed to invalidate_range_start()/end(), if
193193
* called between those functions.
194194
*/
195-
void (*invalidate_range)(struct mmu_notifier *mn, struct mm_struct *mm,
196-
unsigned long start, unsigned long end);
195+
void (*invalidate_range)(struct mmu_notifier *subscription,
196+
struct mm_struct *mm,
197+
unsigned long start,
198+
unsigned long end);
197199

198200
/*
199201
* These callbacks are used with the get/put interface to manage the
@@ -206,7 +208,7 @@ struct mmu_notifier_ops {
206208
* and cannot sleep.
207209
*/
208210
struct mmu_notifier *(*alloc_notifier)(struct mm_struct *mm);
209-
void (*free_notifier)(struct mmu_notifier *mn);
211+
void (*free_notifier)(struct mmu_notifier *subscription);
210212
};
211213

212214
/*
@@ -280,14 +282,14 @@ mmu_notifier_get(const struct mmu_notifier_ops *ops, struct mm_struct *mm)
280282
up_write(&mm->mmap_sem);
281283
return ret;
282284
}
283-
void mmu_notifier_put(struct mmu_notifier *mn);
285+
void mmu_notifier_put(struct mmu_notifier *subscription);
284286
void mmu_notifier_synchronize(void);
285287

286-
extern int mmu_notifier_register(struct mmu_notifier *mn,
288+
extern int mmu_notifier_register(struct mmu_notifier *subscription,
287289
struct mm_struct *mm);
288-
extern int __mmu_notifier_register(struct mmu_notifier *mn,
290+
extern int __mmu_notifier_register(struct mmu_notifier *subscription,
289291
struct mm_struct *mm);
290-
extern void mmu_notifier_unregister(struct mmu_notifier *mn,
292+
extern void mmu_notifier_unregister(struct mmu_notifier *subscription,
291293
struct mm_struct *mm);
292294

293295
unsigned long mmu_interval_read_begin(struct mmu_interval_notifier *mni);

0 commit comments

Comments
 (0)