Skip to content

Commit 19e35f2

Browse files
Tetsuo Handakuba-moo
authored andcommitted
nfc: nci: Fix kcov check in nci_rx_work()
Commit 7e8cdc9 ("nfc: Add KCOV annotations") added kcov_remote_start_common()/kcov_remote_stop() pair into nci_rx_work(), with an assumption that kcov_remote_stop() is called upon continue of the for loop. But commit d24b035 ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") forgot to call kcov_remote_stop() before break of the for loop. Reported-by: syzbot <[email protected]> Closes: https://syzkaller.appspot.com/bug?extid=0438378d6f157baae1a2 Fixes: d24b035 ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") Suggested-by: Andrey Konovalov <[email protected]> Signed-off-by: Tetsuo Handa <[email protected]> Reviewed-by: Krzysztof Kozlowski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 9adcac6 commit 19e35f2

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

net/nfc/nci/core.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1518,6 +1518,7 @@ static void nci_rx_work(struct work_struct *work)
15181518

15191519
if (!nci_plen(skb->data)) {
15201520
kfree_skb(skb);
1521+
kcov_remote_stop();
15211522
break;
15221523
}
15231524

0 commit comments

Comments
 (0)