crypto: cryptd - Fix skcipher instance memory leak

vwax · herbertx · commit 1a0fad630e0b · 2019-07-03T22:11:55.000+08:00
cryptd_skcipher_free() fails to free the struct skcipher_instance allocated in cryptd_create_skcipher(), leading to a memory leak. This is detected by kmemleak on bootup on ARM64 platforms: unreferenced object 0xffff80003377b180 (size 1024): comm "cryptomgr_probe", pid 822, jiffies 4294894830 (age 52.760s) backtrace: kmem_cache_alloc_trace+0x270/0x2d0 cryptd_create+0x990/0x124c cryptomgr_probe+0x5c/0x1e8 kthread+0x258/0x318 ret_from_fork+0x10/0x1c Fixes: 4e0958d ("crypto: cryptd - Add support for skcipher") Cc: <stable@vger.kernel.org> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/crypto/cryptd.c b/crypto/cryptd.c
@@ -393,6 +393,7 @@ static void cryptd_skcipher_free(struct skcipher_instance *inst)
 	struct skcipherd_instance_ctx *ctx = skcipher_instance_ctx(inst);
 
 	crypto_drop_skcipher(&ctx->spawn);
+	kfree(inst);
 }
 
 static int cryptd_create_skcipher(struct crypto_template *tmpl,

Original file line number	Diff line number	Diff line change
`@@ -393,6 +393,7 @@ static void cryptd_skcipher_free(struct skcipher_instance *inst)`
`393`	`393`	`struct skcipherd_instance_ctx *ctx = skcipher_instance_ctx(inst);`
`394`	`394`
`395`	`395`	`crypto_drop_skcipher(&ctx->spawn);`
	`396`	`+ kfree(inst);`
`396`	`397`	`}`
`397`	`398`
`398`	`399`	`static int cryptd_create_skcipher(struct crypto_template *tmpl,`