Skip to content

Commit 1aae306

Browse files
kv2019ivsyrjala
authored andcommitted
drm/i915: Add missing HDMI audio pixel clocks for gen12
Gen12 hardware supports HDMI audio pixel clocks of 296.7/297Mhz and 593.4/594Mhz. Add the missing rates and add logic to ignore them if running on older hardware. Bspec: 49333 Signed-off-by: Kai Vehmanen <[email protected]> Reviewed-by: Ville Syrjälä <[email protected]> Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 4aea5a9 commit 1aae306

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

drivers/gpu/drm/i915/display/intel_audio.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,10 @@ static const struct {
149149
{ 74250, AUD_CONFIG_PIXEL_CLOCK_HDMI_74250 },
150150
{ 148352, AUD_CONFIG_PIXEL_CLOCK_HDMI_148352 },
151151
{ 148500, AUD_CONFIG_PIXEL_CLOCK_HDMI_148500 },
152+
{ 296703, AUD_CONFIG_PIXEL_CLOCK_HDMI_296703 },
153+
{ 297000, AUD_CONFIG_PIXEL_CLOCK_HDMI_297000 },
154+
{ 593407, AUD_CONFIG_PIXEL_CLOCK_HDMI_593407 },
155+
{ 594000, AUD_CONFIG_PIXEL_CLOCK_HDMI_594000 },
152156
};
153157

154158
/* HDMI N/CTS table */
@@ -234,6 +238,7 @@ static const struct hdmi_aud_ncts hdmi_aud_ncts_36bpp[] = {
234238
/* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */
235239
static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_state)
236240
{
241+
struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev);
237242
const struct drm_display_mode *adjusted_mode =
238243
&crtc_state->hw.adjusted_mode;
239244
int i;
@@ -243,6 +248,9 @@ static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_sta
243248
break;
244249
}
245250

251+
if (INTEL_GEN(dev_priv) < 12 && adjusted_mode->crtc_clock > 148500)
252+
i = ARRAY_SIZE(hdmi_audio_clock);
253+
246254
if (i == ARRAY_SIZE(hdmi_audio_clock)) {
247255
DRM_DEBUG_KMS("HDMI audio pixel clock setting for %d not found, falling back to defaults\n",
248256
adjusted_mode->crtc_clock);

drivers/gpu/drm/i915/i915_reg.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9251,6 +9251,10 @@ enum {
92519251
#define AUD_CONFIG_PIXEL_CLOCK_HDMI_74250 (7 << 16)
92529252
#define AUD_CONFIG_PIXEL_CLOCK_HDMI_148352 (8 << 16)
92539253
#define AUD_CONFIG_PIXEL_CLOCK_HDMI_148500 (9 << 16)
9254+
#define AUD_CONFIG_PIXEL_CLOCK_HDMI_296703 (10 << 16)
9255+
#define AUD_CONFIG_PIXEL_CLOCK_HDMI_297000 (11 << 16)
9256+
#define AUD_CONFIG_PIXEL_CLOCK_HDMI_593407 (12 << 16)
9257+
#define AUD_CONFIG_PIXEL_CLOCK_HDMI_594000 (13 << 16)
92549258
#define AUD_CONFIG_DISABLE_NCTS (1 << 3)
92559259

92569260
/* HSW Audio */

0 commit comments

Comments
 (0)