Skip to content

Commit 1b17c6d

Browse files
Andrew BanmanIngo Molnar
authored andcommitted
x86/platform/uv/BAU: Fix HUB errors by remove initial write to sw-ack register
Writing to the software acknowledge clear register when there are no pending messages causes a HUB error to assert. The original intent of this write was to clear the pending bits before start of operation, but this is an incorrect method and has been determined to be unnecessary. Signed-off-by: Andrew Banman <[email protected]> Acked-by: Mike Travis <[email protected]> Cc: Andy Lutomirski <[email protected]> Cc: Borislav Petkov <[email protected]> Cc: Brian Gerst <[email protected]> Cc: Denys Vlasenko <[email protected]> Cc: H. Peter Anvin <[email protected]> Cc: Josh Poimboeuf <[email protected]> Cc: Linus Torvalds <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Ingo Molnar <[email protected]>
1 parent 2a4d0c6 commit 1b17c6d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

arch/x86/platform/uv/tlb_uv.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1847,7 +1847,6 @@ static void pq_init(int node, int pnode)
18471847

18481848
ops.write_payload_first(pnode, first);
18491849
ops.write_payload_last(pnode, last);
1850-
ops.write_g_sw_ack(pnode, 0xffffUL);
18511850

18521851
/* in effect, all msg_type's are set to MSG_NOOP */
18531852
memset(pqp, 0, sizeof(struct bau_pq_entry) * DEST_Q_SIZE);

0 commit comments

Comments
 (0)