Skip to content

Commit 1cc4a01

Browse files
lxinummakynes
authored andcommitted
netfilter: ipvs: fix the issue that sctp_conn_schedule drops non-INIT packet
Commit 5e26b1b ("ipvs: support scheduling inverse and icmp SCTP packets") changed to check packet type early. It introduced a side effect: if it's not a INIT packet, ports will be set as NULL, and the packet will be dropped later. It caused that sctp couldn't create connection when ipvs module is loaded and any scheduler is registered on server. Li Shuang reproduced it by running the cmds on sctp server: # ipvsadm -A -t 1.1.1.1:80 -s rr # ipvsadm -D -t 1.1.1.1:80 then the server could't work any more. This patch is to return 1 when it's not an INIT packet. It means ipvs will accept it without creating a conn for it, just like what it does for tcp. Fixes: 5e26b1b ("ipvs: support scheduling inverse and icmp SCTP packets") Reported-by: Li Shuang <[email protected]> Signed-off-by: Xin Long <[email protected]> Signed-off-by: Simon Horman <[email protected]> Signed-off-by: Pablo Neira Ayuso <[email protected]>
1 parent 8e0deed commit 1cc4a01

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

net/netfilter/ipvs/ip_vs_proto_sctp.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,12 @@ sctp_conn_schedule(struct netns_ipvs *ipvs, int af, struct sk_buff *skb,
2424
if (sh) {
2525
sch = skb_header_pointer(skb, iph->len + sizeof(_sctph),
2626
sizeof(_schunkh), &_schunkh);
27-
if (sch && (sch->type == SCTP_CID_INIT ||
28-
sysctl_sloppy_sctp(ipvs)))
27+
if (sch) {
28+
if (!(sysctl_sloppy_sctp(ipvs) ||
29+
sch->type == SCTP_CID_INIT))
30+
return 1;
2931
ports = &sh->source;
32+
}
3033
}
3134
} else {
3235
ports = skb_header_pointer(

0 commit comments

Comments
 (0)