tlan: cancel work at remove path

Devendra Naga · davem330 · commit 1e0a8b13d355 · 2013-04-16T16:43:34.000-04:00
the work has been scheduled from interrupt, and not been
cancelled when the driver is unloaded, which doesn't remove
the work item from the global workqueue. call the
cancel_work_sync when the driver is removed (rmmod'ed).

Cc: Sriram &lt;srk@ti.com&gt;
Cc: Cyril Chemparathy &lt;cyril@ti.com&gt;
Cc: Vinay Hegde &lt;vinay.hegde@ti.com&gt;
Signed-off-by: Devendra Naga &lt;devendra.aaru@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
@@ -320,6 +320,7 @@ static void tlan_remove_one(struct pci_dev *pdev)
 	free_netdev(dev);
 
 	pci_set_drvdata(pdev, NULL);
+	cancel_work_sync(&priv->tlan_tqueue);
 }
 
 static void tlan_start(struct net_device *dev)

Original file line number	Diff line number	Diff line change
`@@ -320,6 +320,7 @@ static void tlan_remove_one(struct pci_dev *pdev)`
`320`	`320`	`free_netdev(dev);`
`321`	`321`
`322`	`322`	`pci_set_drvdata(pdev, NULL);`
	`323`	`+ cancel_work_sync(&priv->tlan_tqueue);`
`323`	`324`	`}`
`324`	`325`
`325`	`326`	`static void tlan_start(struct net_device *dev)`