Skip to content

Commit 1e63066

Browse files
raven-autorvalds
authored andcommitted
autofs: mount point create should honour passed in mode
The autofs file system mkdir inode operation blindly sets the created directory mode to S_IFDIR | 0555, ingoring the passed in mode, which can cause selinux dac_override denials. But the function also checks if the caller is the daemon (as no-one else should be able to do anything here) so there's no point in not honouring the passed in mode, allowing the daemon to set appropriate mode when required. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Ian Kent <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 1551cf7 commit 1e63066

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/autofs4/root.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -749,7 +749,7 @@ static int autofs4_dir_mkdir(struct inode *dir,
749749

750750
autofs4_del_active(dentry);
751751

752-
inode = autofs4_get_inode(dir->i_sb, S_IFDIR | 0555);
752+
inode = autofs4_get_inode(dir->i_sb, S_IFDIR | mode);
753753
if (!inode)
754754
return -ENOMEM;
755755
d_add(dentry, inode);

0 commit comments

Comments
 (0)