Skip to content

Commit 1e699e1

Browse files
committed
Revert "hwmon: (pmbus) Add regulator supply into macro"
This reverts commit 54cc3db. Zev Weiss reports that the reverted patch may cause a regulator undercount. Here is his report: ... having regulator-dummy set as a supply on my PMBus regulators (instead of having them as their own top-level regulators without an upstream supply) leads to enable-count underflow errors when disabling them: # echo 0 > /sys/bus/platform/devices/efuse01/state [ 906.094477] regulator-dummy: Underflow of regulator enable count [ 906.100563] Failed to disable vout: -EINVAL [ 136.992676] reg-userspace-consumer efuse01: Failed to configure state: -22 Zev reports that reverting the patch fixes the problem. So let's do that for now. Fixes: 54cc3db ("hwmon: (pmbus) Add regulator supply into macro") Cc: Marcello Sylvester Bauer <[email protected]> Reported-by: Zev Weiss <[email protected]> Signed-off-by: Guenter Roeck <[email protected]>
1 parent c4f6837 commit 1e699e1

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/hwmon/pmbus/pmbus.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,6 @@ extern const struct regulator_ops pmbus_regulator_ops;
467467
#define PMBUS_REGULATOR_STEP(_name, _id, _voltages, _step) \
468468
[_id] = { \
469469
.name = (_name # _id), \
470-
.supply_name = "vin", \
471470
.id = (_id), \
472471
.of_match = of_match_ptr(_name # _id), \
473472
.regulators_node = of_match_ptr("regulators"), \

0 commit comments

Comments
 (0)