tcp: correctly crypto_alloc_hash return check

insuyun · davem330 · commit 1eea84b74cd2 · 2016-02-17T22:23:04.000-05:00
crypto_alloc_hash never returns NULL

Signed-off-by: Insu Yun &lt;wuninsu@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
@@ -2950,7 +2950,7 @@ static void __tcp_alloc_md5sig_pool(void)
 			struct crypto_hash *hash;
 
 			hash = crypto_alloc_hash("md5", 0, CRYPTO_ALG_ASYNC);
-			if (IS_ERR_OR_NULL(hash))
+			if (IS_ERR(hash))
 				return;
 			per_cpu(tcp_md5sig_pool, cpu).md5_desc.tfm = hash;
 		}

Original file line number	Diff line number	Diff line change
`@@ -2950,7 +2950,7 @@ static void __tcp_alloc_md5sig_pool(void)`
`2950`	`2950`	`struct crypto_hash *hash;`
`2951`	`2951`
`2952`	`2952`	`hash = crypto_alloc_hash("md5", 0, CRYPTO_ALG_ASYNC);`
`2953`		`- if (IS_ERR_OR_NULL(hash))`
	`2953`	`+ if (IS_ERR(hash))`
`2954`	`2954`	`return;`
`2955`	`2955`	`per_cpu(tcp_md5sig_pool, cpu).md5_desc.tfm = hash;`
`2956`	`2956`	`}`