Skip to content

Commit 1f19aee

Browse files
mpredfearnMarc Zyngier
authored andcommitted
irqchip/mips-gic: Add pr_fmt and reword pr_* messages
Several messages from the MIPS GIC driver include the text "GIC", but the format is not standard. Add a pr_fmt of "irq-mips-gic: " and reword the messages now that they will be prefixed with the driver name. Signed-off-by: Matt Redfearn <[email protected]> Reviewed-by: Paul Burton <[email protected]> Signed-off-by: Marc Zyngier <[email protected]>
1 parent 90af7c2 commit 1f19aee

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

drivers/irqchip/irq-mips-gic.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
* Copyright (C) 2008 Ralf Baechle ([email protected])
77
* Copyright (C) 2012 MIPS Technologies, Inc. All rights reserved.
88
*/
9+
10+
#define pr_fmt(fmt) "irq-mips-gic: " fmt
11+
912
#include <linux/bitmap.h>
1013
#include <linux/clocksource.h>
1114
#include <linux/cpuhotplug.h>
@@ -685,7 +688,7 @@ static int __init gic_of_init(struct device_node *node,
685688

686689
cpu_vec = find_first_zero_bit(&reserved, hweight_long(ST0_IM));
687690
if (cpu_vec == hweight_long(ST0_IM)) {
688-
pr_err("No CPU vectors available for GIC\n");
691+
pr_err("No CPU vectors available\n");
689692
return -ENODEV;
690693
}
691694

@@ -699,7 +702,7 @@ static int __init gic_of_init(struct device_node *node,
699702
~CM_GCR_GIC_BASE_GICEN;
700703
gic_len = 0x20000;
701704
} else {
702-
pr_err("Failed to get GIC memory range\n");
705+
pr_err("Failed to get memory range\n");
703706
return -ENODEV;
704707
}
705708
} else {
@@ -757,7 +760,7 @@ static int __init gic_of_init(struct device_node *node,
757760
gic_shared_intrs, 0,
758761
&gic_irq_domain_ops, NULL);
759762
if (!gic_irq_domain) {
760-
pr_err("Failed to add GIC IRQ domain");
763+
pr_err("Failed to add IRQ domain");
761764
return -ENXIO;
762765
}
763766

@@ -766,7 +769,7 @@ static int __init gic_of_init(struct device_node *node,
766769
GIC_NUM_LOCAL_INTRS + gic_shared_intrs,
767770
node, &gic_ipi_domain_ops, NULL);
768771
if (!gic_ipi_domain) {
769-
pr_err("Failed to add GIC IPI domain");
772+
pr_err("Failed to add IPI domain");
770773
return -ENXIO;
771774
}
772775

0 commit comments

Comments
 (0)