Skip to content

Commit 1f2a300

Browse files
Achiad Shochatdavem330
authored andcommitted
net/mlx5e: Do not use netdev_err() before the netdev is registered
Since it is un-named at this time. Signed-off-by: Achiad Shochat <[email protected]> Signed-off-by: Amir Vadai <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 97de9f3 commit 1f2a300

File tree

1 file changed

+5
-10
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+5
-10
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1893,36 +1893,31 @@ static void *mlx5e_create_netdev(struct mlx5_core_dev *mdev)
18931893

18941894
err = mlx5_alloc_map_uar(mdev, &priv->cq_uar);
18951895
if (err) {
1896-
netdev_err(netdev, "%s: mlx5_alloc_map_uar failed, %d\n",
1897-
__func__, err);
1896+
mlx5_core_err(mdev, "alloc_map uar failed, %d\n", err);
18981897
goto err_free_netdev;
18991898
}
19001899

19011900
err = mlx5_core_alloc_pd(mdev, &priv->pdn);
19021901
if (err) {
1903-
netdev_err(netdev, "%s: mlx5_core_alloc_pd failed, %d\n",
1904-
__func__, err);
1902+
mlx5_core_err(mdev, "alloc pd failed, %d\n", err);
19051903
goto err_unmap_free_uar;
19061904
}
19071905

19081906
err = mlx5_alloc_transport_domain(mdev, &priv->tdn);
19091907
if (err) {
1910-
netdev_err(netdev, "%s: mlx5_alloc_transport_domain failed, %d\n",
1911-
__func__, err);
1908+
mlx5_core_err(mdev, "alloc td failed, %d\n", err);
19121909
goto err_dealloc_pd;
19131910
}
19141911

19151912
err = mlx5e_create_mkey(priv, priv->pdn, &priv->mr);
19161913
if (err) {
1917-
netdev_err(netdev, "%s: mlx5e_create_mkey failed, %d\n",
1918-
__func__, err);
1914+
mlx5_core_err(mdev, "create mkey failed, %d\n", err);
19191915
goto err_dealloc_transport_domain;
19201916
}
19211917

19221918
err = register_netdev(netdev);
19231919
if (err) {
1924-
netdev_err(netdev, "%s: register_netdev failed, %d\n",
1925-
__func__, err);
1920+
mlx5_core_err(mdev, "register_netdev failed, %d\n", err);
19261921
goto err_destroy_mkey;
19271922
}
19281923

0 commit comments

Comments
 (0)