Skip to content

Commit 1f57817

Browse files
Tetsuo Handaebiederm
authored andcommitted
commoncap: Handle memory allocation failure.
syzbot is reporting NULL pointer dereference at xattr_getsecurity() [1], for cap_inode_getsecurity() is returning sizeof(struct vfs_cap_data) when memory allocation failed. Return -ENOMEM if memory allocation failed. [1] https://syzkaller.appspot.com/bug?id=a55ba438506fe68649a5f50d2d82d56b365e0107 Signed-off-by: Tetsuo Handa <[email protected]> Fixes: 8db6c34 ("Introduce v3 namespaced file capabilities") Reported-by: syzbot <[email protected]> Cc: stable <[email protected]> # 4.14+ Acked-by: Serge E. Hallyn <[email protected]> Acked-by: James Morris <[email protected]> Signed-off-by: Eric W. Biederman <[email protected]>
1 parent 2236d4d commit 1f57817

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

security/commoncap.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,8 @@ int cap_inode_getsecurity(struct inode *inode, const char *name, void **buffer,
449449
magic |= VFS_CAP_FLAGS_EFFECTIVE;
450450
memcpy(&cap->data, &nscap->data, sizeof(__le32) * 2 * VFS_CAP_U32);
451451
cap->magic_etc = cpu_to_le32(magic);
452+
} else {
453+
size = -ENOMEM;
452454
}
453455
}
454456
kfree(tmpbuf);

0 commit comments

Comments
 (0)