Skip to content

Commit 1fb3a7a

Browse files
khfengJeff Kirsher
authored andcommitted
igb: Fix an issue that PME is not enabled during runtime suspend
I210 ethernet card doesn't wakeup when a cable gets plugged. It's because its PME is not set. Since commit 42eca23 ("PCI: Don't touch card regs after runtime suspend D3"), if the PCI state is saved, pci_pm_runtime_suspend() stops calling pci_finish_runtime_suspend(), which enables the PCI PME. To fix the issue, let's not to save PCI states when it's runtime suspend, to let the PCI subsystem enables PME. Fixes: 42eca23 ("PCI: Don't touch card regs after runtime suspend D3") Signed-off-by: Kai-Heng Feng <[email protected]> Tested-by: Aaron Brown <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent eec9037 commit 1fb3a7a

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

drivers/net/ethernet/intel/igb/igb_main.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8771,9 +8771,11 @@ static int __igb_shutdown(struct pci_dev *pdev, bool *enable_wake,
87718771
rtnl_unlock();
87728772

87738773
#ifdef CONFIG_PM
8774-
retval = pci_save_state(pdev);
8775-
if (retval)
8776-
return retval;
8774+
if (!runtime) {
8775+
retval = pci_save_state(pdev);
8776+
if (retval)
8777+
return retval;
8778+
}
87778779
#endif
87788780

87798781
status = rd32(E1000_STATUS);

0 commit comments

Comments
 (0)