Skip to content

Commit 1fbd55c

Browse files
committed
Merge tag 'driver-core-4.15-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
Pull driver core fixes from Greg KH: "Here are 3 small fixes for some reported issues: - a debugfs build error that lots of people have reported - a Kconfig help text cleanup now that the firmware is not in the kernel tree - an ISA bus bug fix for a reported issue that has been there since 2.6.18. All of these have been in linux-next with no reported issues" * tag 'driver-core-4.15-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: firmware: cleanup FIRMWARE_IN_KERNEL message isa: Prevent NULL dereference in isa_bus driver callbacks debugfs: fix debugfs_real_fops() build error
2 parents 7399693 + 0946b2f commit 1fbd55c

File tree

3 files changed

+20
-17
lines changed

3 files changed

+20
-17
lines changed

drivers/base/Kconfig

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -91,22 +91,23 @@ config FIRMWARE_IN_KERNEL
9191
depends on FW_LOADER
9292
default y
9393
help
94-
The kernel source tree includes a number of firmware 'blobs'
95-
that are used by various drivers. The recommended way to
96-
use these is to run "make firmware_install", which, after
97-
converting ihex files to binary, copies all of the needed
98-
binary files in firmware/ to /lib/firmware/ on your system so
99-
that they can be loaded by userspace helpers on request.
94+
Various drivers in the kernel source tree may require firmware,
95+
which is generally available in your distribution's linux-firmware
96+
package.
97+
98+
The linux-firmware package should install firmware into
99+
/lib/firmware/ on your system, so they can be loaded by userspace
100+
helpers on request.
100101

101102
Enabling this option will build each required firmware blob
102-
into the kernel directly, where request_firmware() will find
103-
them without having to call out to userspace. This may be
104-
useful if your root file system requires a device that uses
105-
such firmware and do not wish to use an initrd.
103+
specified by EXTRA_FIRMWARE into the kernel directly, where
104+
request_firmware() will find them without having to call out to
105+
userspace. This may be useful if your root file system requires a
106+
device that uses such firmware and you do not wish to use an
107+
initrd.
106108

107109
This single option controls the inclusion of firmware for
108-
every driver that uses request_firmware() and ships its
109-
firmware in the kernel source tree, which avoids a
110+
every driver that uses request_firmware(), which avoids a
110111
proliferation of 'Include firmware for xxx device' options.
111112

112113
Say 'N' and let firmware be loaded from userspace.

drivers/base/isa.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ static int isa_bus_probe(struct device *dev)
3939
{
4040
struct isa_driver *isa_driver = dev->platform_data;
4141

42-
if (isa_driver->probe)
42+
if (isa_driver && isa_driver->probe)
4343
return isa_driver->probe(dev, to_isa_dev(dev)->id);
4444

4545
return 0;
@@ -49,7 +49,7 @@ static int isa_bus_remove(struct device *dev)
4949
{
5050
struct isa_driver *isa_driver = dev->platform_data;
5151

52-
if (isa_driver->remove)
52+
if (isa_driver && isa_driver->remove)
5353
return isa_driver->remove(dev, to_isa_dev(dev)->id);
5454

5555
return 0;
@@ -59,15 +59,15 @@ static void isa_bus_shutdown(struct device *dev)
5959
{
6060
struct isa_driver *isa_driver = dev->platform_data;
6161

62-
if (isa_driver->shutdown)
62+
if (isa_driver && isa_driver->shutdown)
6363
isa_driver->shutdown(dev, to_isa_dev(dev)->id);
6464
}
6565

6666
static int isa_bus_suspend(struct device *dev, pm_message_t state)
6767
{
6868
struct isa_driver *isa_driver = dev->platform_data;
6969

70-
if (isa_driver->suspend)
70+
if (isa_driver && isa_driver->suspend)
7171
return isa_driver->suspend(dev, to_isa_dev(dev)->id, state);
7272

7373
return 0;
@@ -77,7 +77,7 @@ static int isa_bus_resume(struct device *dev)
7777
{
7878
struct isa_driver *isa_driver = dev->platform_data;
7979

80-
if (isa_driver->resume)
80+
if (isa_driver && isa_driver->resume)
8181
return isa_driver->resume(dev, to_isa_dev(dev)->id);
8282

8383
return 0;

include/linux/debugfs.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,8 @@ static inline void debugfs_remove(struct dentry *dentry)
216216
static inline void debugfs_remove_recursive(struct dentry *dentry)
217217
{ }
218218

219+
const struct file_operations *debugfs_real_fops(const struct file *filp);
220+
219221
static inline int debugfs_file_get(struct dentry *dentry)
220222
{
221223
return 0;

0 commit comments

Comments
 (0)