Skip to content

Commit 1ffdb51

Browse files
Mario Limoncielloholtmann
authored andcommitted
Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"
This reverts commit a0085f2. This commit has caused regressions in notebooks that support suspend to idle such as the XPS 9360, XPS 9370 and XPS 9380. These notebooks will wakeup from suspend to idle from an unsolicited advertising packet from an unpaired BLE device. In a bug report it was sugggested that this is caused by a generic lack of LE privacy support. Revert this commit until that behavior can be avoided by the kernel. Fixes: a0085f2 ("Bluetooth: btusb: driver to enable the usb-wakeup feature") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=200039 Link: https://marc.info/?l=linux-bluetooth&m=156441081612627&w=2 Link: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/750073/ CC: Bastien Nocera <[email protected]> CC: Christian Kellner <[email protected]> CC: Sukumar Ghorai <[email protected]> Signed-off-by: Mario Limonciello <[email protected]> Signed-off-by: Marcel Holtmann <[email protected]>
1 parent 8693265 commit 1ffdb51

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/bluetooth/btusb.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1170,10 +1170,6 @@ static int btusb_open(struct hci_dev *hdev)
11701170
}
11711171

11721172
data->intf->needs_remote_wakeup = 1;
1173-
/* device specific wakeup source enabled and required for USB
1174-
* remote wakeup while host is suspended
1175-
*/
1176-
device_wakeup_enable(&data->udev->dev);
11771173

11781174
if (test_and_set_bit(BTUSB_INTR_RUNNING, &data->flags))
11791175
goto done;
@@ -1238,7 +1234,6 @@ static int btusb_close(struct hci_dev *hdev)
12381234
goto failed;
12391235

12401236
data->intf->needs_remote_wakeup = 0;
1241-
device_wakeup_disable(&data->udev->dev);
12421237
usb_autopm_put_interface(data->intf);
12431238

12441239
failed:

0 commit comments

Comments
 (0)