iwlwifi: pcie: fix erroneous return value

aspsk · egrumbach · commit 20aa99bbddae · 2016-02-15T13:38:31.000+02:00
The iwl_trans_pcie_start_fw() function may return the positive value EIO
instead of -EIO in case of error.

Signed-off-by: Anton Protopopov &lt;a.s.protopopov@gmail.com&gt;
Signed-off-by: Emmanuel Grumbach &lt;emmanuel.grumbach@intel.com&gt;
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
@@ -1168,7 +1168,7 @@ static int iwl_trans_pcie_start_fw(struct iwl_trans *trans,
 	if (trans_pcie->is_down) {
 		IWL_WARN(trans,
 			 "Can't start_fw since the HW hasn't been started\n");
-		ret = EIO;
+		ret = -EIO;
 		goto out;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1168,7 +1168,7 @@ static int iwl_trans_pcie_start_fw(struct iwl_trans *trans,`
`1168`	`1168`	`if (trans_pcie->is_down) {`
`1169`	`1169`	`IWL_WARN(trans,`
`1170`	`1170`	`"Can't start_fw since the HW hasn't been started\n");`
`1171`		`- ret = EIO;`
	`1171`	`+ ret = -EIO;`
`1172`	`1172`	`goto out;`
`1173`	`1173`	`}`
`1174`	`1174`