Skip to content

Commit 2139cbe

Browse files
bzolniertorvalds
authored andcommitted
cma: fix counting of isolated pages
Isolated free pages shouldn't be accounted to NR_FREE_PAGES counter. Fix it by properly decreasing/increasing NR_FREE_PAGES counter in set_migratetype_isolate()/unset_migratetype_isolate() and removing counter adjustment for isolated pages from free_one_page() and split_free_page(). Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]> Signed-off-by: Kyungmin Park <[email protected]> Cc: Marek Szyprowski <[email protected]> Cc: Michal Nazarewicz <[email protected]> Cc: Minchan Kim <[email protected]> Cc: Mel Gorman <[email protected]> Cc: Hugh Dickins <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 770c8aa commit 2139cbe

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

mm/page_alloc.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,8 @@ static void free_one_page(struct zone *zone, struct page *page, int order,
691691
zone->pages_scanned = 0;
692692

693693
__free_one_page(page, zone, order, migratetype);
694-
__mod_zone_page_state(zone, NR_FREE_PAGES, 1 << order);
694+
if (unlikely(migratetype != MIGRATE_ISOLATE))
695+
__mod_zone_page_state(zone, NR_FREE_PAGES, 1 << order);
695696
spin_unlock(&zone->lock);
696697
}
697698

@@ -1392,6 +1393,7 @@ int capture_free_page(struct page *page, int alloc_order, int migratetype)
13921393
unsigned int order;
13931394
unsigned long watermark;
13941395
struct zone *zone;
1396+
int mt;
13951397

13961398
BUG_ON(!PageBuddy(page));
13971399

@@ -1407,7 +1409,10 @@ int capture_free_page(struct page *page, int alloc_order, int migratetype)
14071409
list_del(&page->lru);
14081410
zone->free_area[order].nr_free--;
14091411
rmv_page_order(page);
1410-
__mod_zone_page_state(zone, NR_FREE_PAGES, -(1UL << order));
1412+
1413+
mt = get_pageblock_migratetype(page);
1414+
if (unlikely(mt != MIGRATE_ISOLATE))
1415+
__mod_zone_page_state(zone, NR_FREE_PAGES, -(1UL << order));
14111416

14121417
if (alloc_order != order)
14131418
expand(zone, page, alloc_order, order,

mm/page_isolation.c

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,12 @@ int set_migratetype_isolate(struct page *page)
7676

7777
out:
7878
if (!ret) {
79+
unsigned long nr_pages;
80+
7981
set_pageblock_isolate(page);
80-
move_freepages_block(zone, page, MIGRATE_ISOLATE);
82+
nr_pages = move_freepages_block(zone, page, MIGRATE_ISOLATE);
83+
84+
__mod_zone_page_state(zone, NR_FREE_PAGES, -nr_pages);
8185
}
8286

8387
spin_unlock_irqrestore(&zone->lock, flags);
@@ -89,12 +93,14 @@ int set_migratetype_isolate(struct page *page)
8993
void unset_migratetype_isolate(struct page *page, unsigned migratetype)
9094
{
9195
struct zone *zone;
92-
unsigned long flags;
96+
unsigned long flags, nr_pages;
97+
9398
zone = page_zone(page);
9499
spin_lock_irqsave(&zone->lock, flags);
95100
if (get_pageblock_migratetype(page) != MIGRATE_ISOLATE)
96101
goto out;
97-
move_freepages_block(zone, page, migratetype);
102+
nr_pages = move_freepages_block(zone, page, migratetype);
103+
__mod_zone_page_state(zone, NR_FREE_PAGES, nr_pages);
98104
restore_pageblock_isolate(page, migratetype);
99105
out:
100106
spin_unlock_irqrestore(&zone->lock, flags);

0 commit comments

Comments
 (0)