Skip to content

Commit 213ff4b

Browse files
lorddoskiaskdave
authored andcommitted
btrfs: remove redundant local variable in read_block_for_search
The local 'b' variable is only used to directly read values from passed extent buffer. So eliminate it and directly use the input parameter. Furthermore this shrinks the size of the following functions: ./scripts/bloat-o-meter ctree.orig fs/btrfs/ctree.o add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-73 (-73) Function old new delta read_block_for_search.isra 876 871 -5 push_node_left 1112 1044 -68 Total: Before=50348, After=50275, chg -0.14% Reviewed-by: Johannes Thumshirn <[email protected]> Signed-off-by: Nikolay Borisov <[email protected]> Reviewed-by: David Sterba <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent 995e9a1 commit 213ff4b

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

fs/btrfs/ctree.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2335,16 +2335,15 @@ read_block_for_search(struct btrfs_root *root, struct btrfs_path *p,
23352335
struct btrfs_fs_info *fs_info = root->fs_info;
23362336
u64 blocknr;
23372337
u64 gen;
2338-
struct extent_buffer *b = *eb_ret;
23392338
struct extent_buffer *tmp;
23402339
struct btrfs_key first_key;
23412340
int ret;
23422341
int parent_level;
23432342

2344-
blocknr = btrfs_node_blockptr(b, slot);
2345-
gen = btrfs_node_ptr_generation(b, slot);
2346-
parent_level = btrfs_header_level(b);
2347-
btrfs_node_key_to_cpu(b, &first_key, slot);
2343+
blocknr = btrfs_node_blockptr(*eb_ret, slot);
2344+
gen = btrfs_node_ptr_generation(*eb_ret, slot);
2345+
parent_level = btrfs_header_level(*eb_ret);
2346+
btrfs_node_key_to_cpu(*eb_ret, &first_key, slot);
23482347

23492348
tmp = find_extent_buffer(fs_info, blocknr);
23502349
if (tmp) {

0 commit comments

Comments
 (0)