Skip to content

Commit 2152cae

Browse files
yoshfujidavem330
authored andcommitted
ipv6: Do not depend on rt->n in rt6_probe().
Signed-off-by: YOSHIFUJI Hideaki <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 145a362 commit 2152cae

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

net/ipv6/route.c

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -498,28 +498,34 @@ static void rt6_probe(struct rt6_info *rt)
498498
* Router Reachability Probe MUST be rate-limited
499499
* to no more than one per minute.
500500
*/
501-
neigh = rt ? rt->n : NULL;
502-
if (!neigh)
503-
return;
504-
write_lock_bh(&neigh->lock);
505-
if (neigh->nud_state & NUD_VALID) {
506-
write_unlock_bh(&neigh->lock);
501+
if (!rt || !(rt->rt6i_flags & RTF_GATEWAY))
507502
return;
503+
rcu_read_lock_bh();
504+
neigh = __ipv6_neigh_lookup_noref(rt->dst.dev, &rt->rt6i_gateway);
505+
if (neigh) {
506+
write_lock(&neigh->lock);
507+
if (neigh->nud_state & NUD_VALID)
508+
goto out;
508509
}
509-
if (!(neigh->nud_state & NUD_VALID) &&
510+
511+
if (!neigh ||
510512
time_after(jiffies, neigh->updated + rt->rt6i_idev->cnf.rtr_probe_interval)) {
511513
struct in6_addr mcaddr;
512514
struct in6_addr *target;
513515

514516
neigh->updated = jiffies;
515-
write_unlock_bh(&neigh->lock);
516517

517-
target = (struct in6_addr *)&neigh->primary_key;
518+
if (neigh)
519+
write_unlock(&neigh->lock);
520+
521+
target = (struct in6_addr *)&rt->rt6i_gateway;
518522
addrconf_addr_solict_mult(target, &mcaddr);
519523
ndisc_send_ns(rt->dst.dev, NULL, target, &mcaddr, NULL);
520524
} else {
521-
write_unlock_bh(&neigh->lock);
525+
out:
526+
write_unlock(&neigh->lock);
522527
}
528+
rcu_read_unlock_bh();
523529
}
524530
#else
525531
static inline void rt6_probe(struct rt6_info *rt)

0 commit comments

Comments
 (0)