Skip to content

Commit 21bf440

Browse files
jhnikulaWolfram Sang
authored andcommitted
i2c: designware: Make HW init functions static
Recent i2c-designware slave support patches use master or slave HW init functions through the function pointer so we can declare them static. While at it, rename i2c_dw_init() as i2c_dw_init_master(). Signed-off-by: Jarkko Nikula <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Tested-by: Luis Oliveira <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 9809cb8 commit 21bf440

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

drivers/i2c/busses/i2c-designware-core.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,8 +306,6 @@ int i2c_dw_handle_tx_abort(struct dw_i2c_dev *dev);
306306
u32 i2c_dw_func(struct i2c_adapter *adap);
307307
void i2c_dw_disable(struct dw_i2c_dev *dev);
308308
void i2c_dw_disable_int(struct dw_i2c_dev *dev);
309-
int i2c_dw_init(struct dw_i2c_dev *dev);
310-
int i2c_dw_init_slave(struct dw_i2c_dev *dev);
311309

312310
extern u32 i2c_dw_read_comp_param(struct dw_i2c_dev *dev);
313311
extern int i2c_dw_probe(struct dw_i2c_dev *dev);

drivers/i2c/busses/i2c-designware-master.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ static void i2c_dw_configure_fifo_master(struct dw_i2c_dev *dev)
5151
* This function is called during I2C init function, and in case of timeout at
5252
* run time.
5353
*/
54-
int i2c_dw_init(struct dw_i2c_dev *dev)
54+
static int i2c_dw_init_master(struct dw_i2c_dev *dev)
5555
{
5656
u32 hcnt, lcnt;
5757
u32 reg, comp_param1;
@@ -171,7 +171,6 @@ int i2c_dw_init(struct dw_i2c_dev *dev)
171171

172172
return 0;
173173
}
174-
EXPORT_SYMBOL_GPL(i2c_dw_init);
175174

176175
static void i2c_dw_xfer_init(struct dw_i2c_dev *dev)
177176
{
@@ -444,7 +443,7 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
444443
if (!wait_for_completion_timeout(&dev->cmd_complete, adap->timeout)) {
445444
dev_err(dev->dev, "controller timed out\n");
446445
/* i2c_dw_init implicitly disables the adapter */
447-
i2c_dw_init(dev);
446+
i2c_dw_init_master(dev);
448447
ret = -ETIMEDOUT;
449448
goto done;
450449
}
@@ -622,7 +621,7 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
622621

623622
init_completion(&dev->cmd_complete);
624623

625-
dev->init = i2c_dw_init;
624+
dev->init = i2c_dw_init_master;
626625
dev->disable = i2c_dw_disable;
627626
dev->disable_int = i2c_dw_disable_int;
628627

drivers/i2c/busses/i2c-designware-slave.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ static void i2c_dw_configure_fifo_slave(struct dw_i2c_dev *dev)
4949
* This function is called during I2C init function, and in case of timeout at
5050
* run time.
5151
*/
52-
int i2c_dw_init_slave(struct dw_i2c_dev *dev)
52+
static int i2c_dw_init_slave(struct dw_i2c_dev *dev)
5353
{
5454
u32 sda_falling_time, scl_falling_time;
5555
u32 reg, comp_param1;
@@ -168,7 +168,6 @@ int i2c_dw_init_slave(struct dw_i2c_dev *dev)
168168

169169
return 0;
170170
}
171-
EXPORT_SYMBOL_GPL(i2c_dw_init_slave);
172171

173172
static int i2c_dw_reg_slave(struct i2c_client *slave)
174173
{

0 commit comments

Comments
 (0)