Skip to content

Commit 21e2d9d

Browse files
committed
Merge branches 'acpica-fixes', 'acpi-pci-fixes' and 'acpi-apei-fixes'
* acpica-fixes: ACPICA: Dispatcher: Fix interpreter locking around acpi_ev_initialize_region() ACPICA: Dispatcher: Fix an unbalanced lock exit path in acpi_ds_auto_serialize_method() ACPICA: Dispatcher: Fix order issue of method termination * acpi-pci-fixes: ACPI/PCI: pci_link: Include PIRQ_PENALTY_PCI_USING for ISA IRQs ACPI/PCI: pci_link: penalize SCI correctly ACPI/PCI/IRQ: assign ISA IRQ directly during early boot stages * acpi-apei-fixes: ACPI / APEI: Fix incorrect return value of ghes_proc()
3 parents 8633db6 + 98756f5 + 806487a commit 21e2d9d

File tree

4 files changed

+24
-18
lines changed

4 files changed

+24
-18
lines changed

arch/x86/kernel/acpi/boot.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -454,6 +454,7 @@ static void __init acpi_sci_ioapic_setup(u8 bus_irq, u16 polarity, u16 trigger,
454454
polarity = acpi_sci_flags & ACPI_MADT_POLARITY_MASK;
455455

456456
mp_override_legacy_irq(bus_irq, polarity, trigger, gsi);
457+
acpi_penalize_sci_irq(bus_irq, trigger, polarity);
457458

458459
/*
459460
* stash over-ride to indicate we've been here

drivers/acpi/apei/ghes.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes)
662662
ghes_do_proc(ghes, ghes->estatus);
663663
out:
664664
ghes_clear_estatus(ghes);
665-
return 0;
665+
return rc;
666666
}
667667

668668
static void ghes_add_timer(struct ghes *ghes)

drivers/acpi/pci_link.c

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ struct acpi_pci_link {
8787

8888
static LIST_HEAD(acpi_link_list);
8989
static DEFINE_MUTEX(acpi_link_lock);
90+
static int sci_irq = -1, sci_penalty;
9091

9192
/* --------------------------------------------------------------------------
9293
PCI Link Device Management
@@ -496,25 +497,13 @@ static int acpi_irq_get_penalty(int irq)
496497
{
497498
int penalty = 0;
498499

499-
/*
500-
* Penalize IRQ used by ACPI SCI. If ACPI SCI pin attributes conflict
501-
* with PCI IRQ attributes, mark ACPI SCI as ISA_ALWAYS so it won't be
502-
* use for PCI IRQs.
503-
*/
504-
if (irq == acpi_gbl_FADT.sci_interrupt) {
505-
u32 type = irq_get_trigger_type(irq) & IRQ_TYPE_SENSE_MASK;
506-
507-
if (type != IRQ_TYPE_LEVEL_LOW)
508-
penalty += PIRQ_PENALTY_ISA_ALWAYS;
509-
else
510-
penalty += PIRQ_PENALTY_PCI_USING;
511-
}
500+
if (irq == sci_irq)
501+
penalty += sci_penalty;
512502

513503
if (irq < ACPI_MAX_ISA_IRQS)
514504
return penalty + acpi_isa_irq_penalty[irq];
515505

516-
penalty += acpi_irq_pci_sharing_penalty(irq);
517-
return penalty;
506+
return penalty + acpi_irq_pci_sharing_penalty(irq);
518507
}
519508

520509
int __init acpi_irq_penalty_init(void)
@@ -619,6 +608,10 @@ static int acpi_pci_link_allocate(struct acpi_pci_link *link)
619608
acpi_device_bid(link->device));
620609
return -ENODEV;
621610
} else {
611+
if (link->irq.active < ACPI_MAX_ISA_IRQS)
612+
acpi_isa_irq_penalty[link->irq.active] +=
613+
PIRQ_PENALTY_PCI_USING;
614+
622615
printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n",
623616
acpi_device_name(link->device),
624617
acpi_device_bid(link->device), link->irq.active);
@@ -849,7 +842,7 @@ static int __init acpi_irq_penalty_update(char *str, int used)
849842
continue;
850843

851844
if (used)
852-
new_penalty = acpi_irq_get_penalty(irq) +
845+
new_penalty = acpi_isa_irq_penalty[irq] +
853846
PIRQ_PENALTY_ISA_USED;
854847
else
855848
new_penalty = 0;
@@ -871,7 +864,7 @@ static int __init acpi_irq_penalty_update(char *str, int used)
871864
void acpi_penalize_isa_irq(int irq, int active)
872865
{
873866
if ((irq >= 0) && (irq < ARRAY_SIZE(acpi_isa_irq_penalty)))
874-
acpi_isa_irq_penalty[irq] = acpi_irq_get_penalty(irq) +
867+
acpi_isa_irq_penalty[irq] +=
875868
(active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING);
876869
}
877870

@@ -881,6 +874,17 @@ bool acpi_isa_irq_available(int irq)
881874
acpi_irq_get_penalty(irq) < PIRQ_PENALTY_ISA_ALWAYS);
882875
}
883876

877+
void acpi_penalize_sci_irq(int irq, int trigger, int polarity)
878+
{
879+
sci_irq = irq;
880+
881+
if (trigger == ACPI_MADT_TRIGGER_LEVEL &&
882+
polarity == ACPI_MADT_POLARITY_ACTIVE_LOW)
883+
sci_penalty = PIRQ_PENALTY_PCI_USING;
884+
else
885+
sci_penalty = PIRQ_PENALTY_ISA_ALWAYS;
886+
}
887+
884888
/*
885889
* Over-ride default table to reserve additional IRQs for use by ISA
886890
* e.g. acpi_irq_isa=5

include/linux/acpi.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@ struct pci_dev;
326326
int acpi_pci_irq_enable (struct pci_dev *dev);
327327
void acpi_penalize_isa_irq(int irq, int active);
328328
bool acpi_isa_irq_available(int irq);
329+
void acpi_penalize_sci_irq(int irq, int trigger, int polarity);
329330
void acpi_pci_irq_disable (struct pci_dev *dev);
330331

331332
extern int ec_read(u8 addr, u8 *val);

0 commit comments

Comments
 (0)