Skip to content

Commit 21f2296

Browse files
Anton SalikhmetovChristoph Hellwig
authored andcommitted
hfsplus: C99 comments clean-up
Match coding style restriction against C99 comments where checkpatch.pl reported errors about their usage. Signed-off-by: Anton Salikhmetov <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
1 parent 2753cc2 commit 21f2296

File tree

3 files changed

+16
-13
lines changed

3 files changed

+16
-13
lines changed

fs/hfsplus/bnode.c

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,15 @@ void hfs_bnode_read(struct hfs_bnode *node, void *buf, int off, int len)
4242
u16 hfs_bnode_read_u16(struct hfs_bnode *node, int off)
4343
{
4444
__be16 data;
45-
// optimize later...
45+
/* TODO: optimize later... */
4646
hfs_bnode_read(node, &data, off, 2);
4747
return be16_to_cpu(data);
4848
}
4949

5050
u8 hfs_bnode_read_u8(struct hfs_bnode *node, int off)
5151
{
5252
u8 data;
53-
// optimize later...
53+
/* TODO: optimize later... */
5454
hfs_bnode_read(node, &data, off, 1);
5555
return data;
5656
}
@@ -96,7 +96,7 @@ void hfs_bnode_write(struct hfs_bnode *node, void *buf, int off, int len)
9696
void hfs_bnode_write_u16(struct hfs_bnode *node, int off, u16 data)
9797
{
9898
__be16 v = cpu_to_be16(data);
99-
// optimize later...
99+
/* TODO: optimize later... */
100100
hfs_bnode_write(node, &v, off, 2);
101101
}
102102

@@ -362,7 +362,7 @@ void hfs_bnode_unlink(struct hfs_bnode *node)
362362
} else if (node->type == HFS_NODE_LEAF)
363363
tree->leaf_tail = node->prev;
364364

365-
// move down?
365+
/* move down? */
366366
if (!node->prev && !node->next) {
367367
dprint(DBG_BNODE_MOD, "hfs_btree_del_level\n");
368368
}
@@ -569,11 +569,13 @@ struct hfs_bnode *hfs_bnode_find(struct hfs_btree *tree, u32 num)
569569

570570
void hfs_bnode_free(struct hfs_bnode *node)
571571
{
572-
//int i;
572+
#if 0
573+
int i;
573574

574-
//for (i = 0; i < node->tree->pages_per_bnode; i++)
575-
// if (node->page[i])
576-
// page_cache_release(node->page[i]);
575+
for (i = 0; i < node->tree->pages_per_bnode; i++)
576+
if (node->page[i])
577+
page_cache_release(node->page[i]);
578+
#endif
577579
kfree(node);
578580
}
579581

fs/hfsplus/extents.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ int hfsplus_file_extend(struct inode *inode)
399399

400400
if (sbi->alloc_file->i_size * 8 <
401401
sbi->total_blocks - sbi->free_blocks + 8) {
402-
// extend alloc file
402+
/* extend alloc file */
403403
printk(KERN_ERR "hfs: extend alloc file! (%Lu,%u,%u)\n",
404404
sbi->alloc_file->i_size * 8,
405405
sbi->total_blocks, sbi->free_blocks);

fs/hfsplus/hfsplus_fs.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,11 @@
2323
#define DBG_EXTENT 0x00000020
2424
#define DBG_BITMAP 0x00000040
2525

26-
//#define DBG_MASK (DBG_EXTENT|DBG_INODE|DBG_BNODE_MOD)
27-
//#define DBG_MASK (DBG_BNODE_MOD|DBG_CAT_MOD|DBG_INODE)
28-
//#define DBG_MASK (DBG_CAT_MOD|DBG_BNODE_REFS|DBG_INODE|DBG_EXTENT)
26+
#if 0
27+
#define DBG_MASK (DBG_EXTENT|DBG_INODE|DBG_BNODE_MOD)
28+
#define DBG_MASK (DBG_BNODE_MOD|DBG_CAT_MOD|DBG_INODE)
29+
#define DBG_MASK (DBG_CAT_MOD|DBG_BNODE_REFS|DBG_INODE|DBG_EXTENT)
30+
#endif
2931
#define DBG_MASK (0)
3032

3133
#define dprint(flg, fmt, args...) \
@@ -62,7 +64,6 @@ struct hfs_btree {
6264
unsigned int max_key_len;
6365
unsigned int depth;
6466

65-
//unsigned int map1_size, map_size;
6667
struct mutex tree_lock;
6768

6869
unsigned int pages_per_bnode;

0 commit comments

Comments
 (0)