Skip to content

Commit 22008f5

Browse files
lxindavem330
authored andcommitted
Revert "Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK""
This reverts commit 7e9269a. As Jere notice, commit 35b4f24 ("sctp: do asoc update earlier in sctp_sf_do_dupcook_a") only keeps the SHUTDOWN and COOKIE-ACK with the same asoc, not transport. So we have to bring this patch back. Reported-by: Jere Leppänen <[email protected]> Signed-off-by: Xin Long <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 643001b commit 22008f5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

net/sctp/sm_statefuns.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1903,7 +1903,7 @@ static enum sctp_disposition sctp_sf_do_dupcook_a(
19031903
*/
19041904
sctp_add_cmd_sf(commands, SCTP_CMD_REPLY, SCTP_CHUNK(repl));
19051905
return sctp_sf_do_9_2_start_shutdown(net, ep, asoc,
1906-
SCTP_ST_CHUNK(0), NULL,
1906+
SCTP_ST_CHUNK(0), repl,
19071907
commands);
19081908
} else {
19091909
sctp_add_cmd_sf(commands, SCTP_CMD_NEW_STATE,
@@ -5549,7 +5549,7 @@ enum sctp_disposition sctp_sf_do_9_2_start_shutdown(
55495549
* in the Cumulative TSN Ack field the last sequential TSN it
55505550
* has received from the peer.
55515551
*/
5552-
reply = sctp_make_shutdown(asoc, NULL);
5552+
reply = sctp_make_shutdown(asoc, arg);
55535553
if (!reply)
55545554
goto nomem;
55555555

@@ -6147,7 +6147,7 @@ enum sctp_disposition sctp_sf_autoclose_timer_expire(
61476147
disposition = SCTP_DISPOSITION_CONSUME;
61486148
if (sctp_outq_is_empty(&asoc->outqueue)) {
61496149
disposition = sctp_sf_do_9_2_start_shutdown(net, ep, asoc, type,
6150-
arg, commands);
6150+
NULL, commands);
61516151
}
61526152

61536153
return disposition;

0 commit comments

Comments
 (0)