Skip to content

Commit 2208cda

Browse files
vingu-linaroPeter Zijlstra
authored andcommitted
sched/fair: Reduce minimal imbalance threshold
The 25% default imbalance threshold for DIE and NUMA domain is large enough to generate significant unfairness between threads. A typical example is the case of 11 threads running on 2x4 CPUs. The imbalance of 20% between the 2 groups of 4 cores is just low enough to not trigger the load balance between the 2 groups. We will have always the same 6 threads on one group of 4 CPUs and the other 5 threads on the other group of CPUS. With a fair time sharing in each group, we ends up with +20% running time for the group of 5 threads. Consider decreasing the imbalance threshold for overloaded case where we use the load to balance task and to ensure fair time sharing. Signed-off-by: Vincent Guittot <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Reviewed-by: Phil Auld <[email protected]> Acked-by: Hillf Danton <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 5a7f555 commit 2208cda

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/sched/topology.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1349,7 +1349,7 @@ sd_init(struct sched_domain_topology_level *tl,
13491349
.min_interval = sd_weight,
13501350
.max_interval = 2*sd_weight,
13511351
.busy_factor = 32,
1352-
.imbalance_pct = 125,
1352+
.imbalance_pct = 117,
13531353

13541354
.cache_nice_tries = 0,
13551355

0 commit comments

Comments
 (0)