Skip to content

Commit 2236543

Browse files
Marek Vasutmarckleinebudde
authored andcommitted
can: ifi: Fix RX and TX ID mask
The RX and TX ID mask for CAN2.0 is 11 bits wide. This patch fixes the incorrect mask, which caused the CAN IDs to miss the MSBit both on receive and transmit. Signed-off-by: Marek Vasut <[email protected]> Cc: Marc Kleine-Budde <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Oliver Hartkopp <[email protected]> Cc: Wolfgang Grandegger <[email protected]> Reviewed-by: Oliver Hartkopp <[email protected]> Signed-off-by: Marc Kleine-Budde <[email protected]>
1 parent f1deaee commit 2236543

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/net/can/ifi_canfd/ifi_canfd.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@
135135

136136
#define IFI_CANFD_RXFIFO_ID 0x6c
137137
#define IFI_CANFD_RXFIFO_ID_ID_OFFSET 0
138-
#define IFI_CANFD_RXFIFO_ID_ID_STD_MASK 0x3ff
139-
#define IFI_CANFD_RXFIFO_ID_ID_XTD_MASK 0x1fffffff
138+
#define IFI_CANFD_RXFIFO_ID_ID_STD_MASK CAN_SFF_MASK
139+
#define IFI_CANFD_RXFIFO_ID_ID_XTD_MASK CAN_EFF_MASK
140140
#define IFI_CANFD_RXFIFO_ID_IDE BIT(29)
141141

142142
#define IFI_CANFD_RXFIFO_DATA 0x70 /* 0x70..0xac */
@@ -156,8 +156,8 @@
156156

157157
#define IFI_CANFD_TXFIFO_ID 0xbc
158158
#define IFI_CANFD_TXFIFO_ID_ID_OFFSET 0
159-
#define IFI_CANFD_TXFIFO_ID_ID_STD_MASK 0x3ff
160-
#define IFI_CANFD_TXFIFO_ID_ID_XTD_MASK 0x1fffffff
159+
#define IFI_CANFD_TXFIFO_ID_ID_STD_MASK CAN_SFF_MASK
160+
#define IFI_CANFD_TXFIFO_ID_ID_XTD_MASK CAN_EFF_MASK
161161
#define IFI_CANFD_TXFIFO_ID_IDE BIT(29)
162162

163163
#define IFI_CANFD_TXFIFO_DATA 0xc0 /* 0xb0..0xfc */

0 commit comments

Comments
 (0)