Skip to content

Commit 223b32d

Browse files
committed
Merge branch 'net-iucv-next'
Julian Wiedmann says: ==================== net/iucv: updates 2020-10-01 Just two (rare) patches, and both deal with smatch warnings. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 8e1b388 + a29f245 commit 223b32d

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

net/iucv/af_iucv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -588,11 +588,11 @@ static int iucv_sock_bind(struct socket *sock, struct sockaddr *addr,
588588
int addr_len)
589589
{
590590
struct sockaddr_iucv *sa = (struct sockaddr_iucv *) addr;
591+
char uid[sizeof(sa->siucv_user_id)];
591592
struct sock *sk = sock->sk;
592593
struct iucv_sock *iucv;
593594
int err = 0;
594595
struct net_device *dev;
595-
char uid[9];
596596

597597
/* Verify the input sockaddr */
598598
if (addr_len < sizeof(struct sockaddr_iucv) ||

net/iucv/iucv.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1116,10 +1116,9 @@ int __iucv_message_receive(struct iucv_path *path, struct iucv_message *msg,
11161116
if (msg->flags & IUCV_IPRMDATA)
11171117
return iucv_message_receive_iprmdata(path, msg, flags,
11181118
buffer, size, residual);
1119-
if (cpumask_empty(&iucv_buffer_cpumask)) {
1120-
rc = -EIO;
1121-
goto out;
1122-
}
1119+
if (cpumask_empty(&iucv_buffer_cpumask))
1120+
return -EIO;
1121+
11231122
parm = iucv_param[smp_processor_id()];
11241123
memset(parm, 0, sizeof(union iucv_param));
11251124
parm->db.ipbfadr1 = (u32)(addr_t) buffer;
@@ -1135,7 +1134,6 @@ int __iucv_message_receive(struct iucv_path *path, struct iucv_message *msg,
11351134
if (residual)
11361135
*residual = parm->db.ipbfln1f;
11371136
}
1138-
out:
11391137
return rc;
11401138
}
11411139
EXPORT_SYMBOL(__iucv_message_receive);

0 commit comments

Comments
 (0)