Skip to content

Commit 233fd21

Browse files
Eli BritsteinSaeed Mahameed
authored andcommitted
net/mlx5e: Simplify get_route_and_out_devs helper function
The helper function has "if" branches that do the same. Merge them to simplify the code. Signed-off-by: Eli Britstein <[email protected]> Reviewed-by: Roi Dayan <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent aae6715 commit 233fd21

File tree

1 file changed

+7
-12
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core/en

1 file changed

+7
-12
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,15 @@ static int get_route_and_out_devs(struct mlx5e_priv *priv,
4040
/* if the egress device isn't on the same HW e-switch or
4141
* it's a LAG device, use the uplink
4242
*/
43+
*route_dev = dev;
4344
if (!netdev_port_same_parent_id(priv->netdev, real_dev) ||
44-
dst_is_lag_dev) {
45-
*route_dev = dev;
45+
dst_is_lag_dev || is_vlan_dev(*route_dev))
4646
*out_dev = uplink_dev;
47-
} else {
48-
*route_dev = dev;
49-
if (is_vlan_dev(*route_dev))
50-
*out_dev = uplink_dev;
51-
else if (mlx5e_eswitch_rep(dev) &&
52-
mlx5e_is_valid_eswitch_fwd_dev(priv, dev))
53-
*out_dev = *route_dev;
54-
else
55-
return -EOPNOTSUPP;
56-
}
47+
else if (mlx5e_eswitch_rep(dev) &&
48+
mlx5e_is_valid_eswitch_fwd_dev(priv, dev))
49+
*out_dev = *route_dev;
50+
else
51+
return -EOPNOTSUPP;
5752

5853
if (!(mlx5e_eswitch_rep(*out_dev) &&
5954
mlx5e_is_uplink_rep(netdev_priv(*out_dev))))

0 commit comments

Comments
 (0)