Skip to content

Commit 24d74b9

Browse files
Jiaxi Chenbonzini
authored andcommitted
KVM: x86: Advertise AVX-VNNI-INT8 CPUID to user space
AVX-VNNI-INT8 is a new set of instructions in the latest Intel platform Sierra Forest, aims for the platform to have superior AI capabilities. This instruction multiplies the individual bytes of two unsigned or unsigned source operands, then adds and accumulates the results into the destination dword element size operand. The bit definition: CPUID.(EAX=7,ECX=1):EDX[bit 4] AVX-VNNI-INT8 is on a new and sparse CPUID leaf and all bits on this leaf have no truly kernel use case for now. Given that and to save space for kernel feature bits, move this new leaf to KVM-only subleaf and plus an x86_FEATURE definition for AVX-VNNI-INT8 to direct it to the KVM entry. Advertise AVX-VNNI-INT8 to KVM userspace. This is safe because there are no new VMX controls or additional host enabling required for guests to use this feature. Signed-off-by: Jiaxi Chen <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 5e85c4e commit 24d74b9

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

arch/x86/kvm/cpuid.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,6 +667,10 @@ void kvm_set_cpu_caps(void)
667667
F(AVX_IFMA)
668668
);
669669

670+
kvm_cpu_cap_init_kvm_defined(CPUID_7_1_EDX,
671+
F(AVX_VNNI_INT8)
672+
);
673+
670674
kvm_cpu_cap_mask(CPUID_D_1_EAX,
671675
F(XSAVEOPT) | F(XSAVEC) | F(XGETBV1) | F(XSAVES) | f_xfd
672676
);
@@ -920,9 +924,9 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function)
920924
goto out;
921925

922926
cpuid_entry_override(entry, CPUID_7_1_EAX);
927+
cpuid_entry_override(entry, CPUID_7_1_EDX);
923928
entry->ebx = 0;
924929
entry->ecx = 0;
925-
entry->edx = 0;
926930
}
927931
break;
928932
case 0xa: { /* Architectural Performance Monitoring */

arch/x86/kvm/reverse_cpuid.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
*/
1414
enum kvm_only_cpuid_leafs {
1515
CPUID_12_EAX = NCAPINTS,
16+
CPUID_7_1_EDX,
1617
NR_KVM_CPU_CAPS,
1718

1819
NKVMCAPINTS = NR_KVM_CPU_CAPS - NCAPINTS,
@@ -36,6 +37,9 @@ enum kvm_only_cpuid_leafs {
3637
#define KVM_X86_FEATURE_SGX1 KVM_X86_FEATURE(CPUID_12_EAX, 0)
3738
#define KVM_X86_FEATURE_SGX2 KVM_X86_FEATURE(CPUID_12_EAX, 1)
3839

40+
/* Intel-defined sub-features, CPUID level 0x00000007:1 (EDX) */
41+
#define X86_FEATURE_AVX_VNNI_INT8 KVM_X86_FEATURE(CPUID_7_1_EDX, 4)
42+
3943
struct cpuid_reg {
4044
u32 function;
4145
u32 index;
@@ -60,6 +64,7 @@ static const struct cpuid_reg reverse_cpuid[] = {
6064
[CPUID_7_1_EAX] = { 7, 1, CPUID_EAX},
6165
[CPUID_12_EAX] = {0x00000012, 0, CPUID_EAX},
6266
[CPUID_8000_001F_EAX] = {0x8000001f, 0, CPUID_EAX},
67+
[CPUID_7_1_EDX] = { 7, 1, CPUID_EDX},
6368
};
6469

6570
/*

0 commit comments

Comments
 (0)