Skip to content

Commit 253c962

Browse files
sergey-senozhatskypmladek
authored andcommitted
ia64: do not use print_symbol()
print_symbol() is a very old API that has been obsoleted by %pS format specifier in a normal printk() call. Replace print_symbol() with a direct printk("%pS") call and avoid using continuous lines. Link: http://lkml.kernel.org/r/[email protected] To: Andrew Morton <[email protected]> To: Russell King <[email protected]> To: Catalin Marinas <[email protected]> To: Mark Salter <[email protected]> To: Tony Luck <[email protected]> To: David Howells <[email protected]> To: Yoshinori Sato <[email protected]> To: Guan Xuetao <[email protected]> To: Borislav Petkov <[email protected]> To: Greg Kroah-Hartman <[email protected]> To: Thomas Gleixner <[email protected]> To: Peter Zijlstra <[email protected]> To: Vineet Gupta <[email protected]> To: Fengguang Wu <[email protected]> Cc: Steven Rostedt <[email protected]> Cc: Petr Mladek <[email protected]> Cc: LKML <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Signed-off-by: Sergey Senozhatsky <[email protected]> [[email protected]: updated commit message] Signed-off-by: Petr Mladek <[email protected]>
1 parent 4717fc1 commit 253c962

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

arch/ia64/kernel/process.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include <linux/pm.h>
1414
#include <linux/elf.h>
1515
#include <linux/errno.h>
16-
#include <linux/kallsyms.h>
1716
#include <linux/kernel.h>
1817
#include <linux/mm.h>
1918
#include <linux/slab.h>
@@ -69,7 +68,6 @@ void
6968
ia64_do_show_stack (struct unw_frame_info *info, void *arg)
7069
{
7170
unsigned long ip, sp, bsp;
72-
char buf[128]; /* don't make it so big that it overflows the stack! */
7371

7472
printk("\nCall Trace:\n");
7573
do {
@@ -79,11 +77,9 @@ ia64_do_show_stack (struct unw_frame_info *info, void *arg)
7977

8078
unw_get_sp(info, &sp);
8179
unw_get_bsp(info, &bsp);
82-
snprintf(buf, sizeof(buf),
83-
" [<%016lx>] %%s\n"
80+
printk(" [<%016lx>] %pS\n"
8481
" sp=%016lx bsp=%016lx\n",
85-
ip, sp, bsp);
86-
print_symbol(buf, ip);
82+
ip, (void *)ip, sp, bsp);
8783
} while (unw_unwind(info) >= 0);
8884
}
8985

@@ -111,7 +107,7 @@ show_regs (struct pt_regs *regs)
111107
printk("psr : %016lx ifs : %016lx ip : [<%016lx>] %s (%s)\n",
112108
regs->cr_ipsr, regs->cr_ifs, ip, print_tainted(),
113109
init_utsname()->release);
114-
print_symbol("ip is at %s\n", ip);
110+
printk("ip is at %pS\n", (void *)ip);
115111
printk("unat: %016lx pfs : %016lx rsc : %016lx\n",
116112
regs->ar_unat, regs->ar_pfs, regs->ar_rsc);
117113
printk("rnat: %016lx bsps: %016lx pr : %016lx\n",

0 commit comments

Comments
 (0)