Bluetooth: btrtl: check for NULL in btrtl_set_quirks()

rtkbt-max · Vudentz · commit 253cf30e8d3d · 2023-04-23T21:57:00.000-07:00
The btrtl_set_quirks() has accessed btrtl_dev-&gt;ic_info-&gt;lmp_subver since
b8e482d02513. However, if installing a Realtek Bluetooth controller
without the driver supported, it will hit the NULL point accessed.

Add a check for NULL to avoid the Kernel Oops.

Signed-off-by: Max Chou &lt;max.chou@realtek.com&gt;
Signed-off-by: Luiz Augusto von Dentz &lt;luiz.von.dentz@intel.com&gt;
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
@@ -905,6 +905,9 @@ void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
 		break;
 	}
 
+	if (!btrtl_dev->ic_info)
+		return;
+
 	switch (btrtl_dev->ic_info->lmp_subver) {
 	case RTL_ROM_LMP_8703B:
 		/* 8723CS reports two pages for local ext features,

Original file line number	Diff line number	Diff line change
`@@ -905,6 +905,9 @@ void btrtl_set_quirks(struct hci_dev hdev, struct btrtl_device_info btrtl_dev)`
`905`	`905`	`break;`
`906`	`906`	`}`
`907`	`907`
	`908`	`+ if (!btrtl_dev->ic_info)`
	`909`	`+ return;`
	`910`	`+`
`908`	`911`	`switch (btrtl_dev->ic_info->lmp_subver) {`
`909`	`912`	`case RTL_ROM_LMP_8703B:`
`910`	`913`	`/* 8723CS reports two pages for local ext features,`